Please disable LibreSSL workaround when LibreSSL version >= 4.0.0 #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Commit 0c92483 allowed to compile i2pd with LibreSSL >= 3.9, but this workaround is not necessary anymore with LibreSSL 4.0.0, and could needlessly leave copies of secrets in memory.
LibreSSL 4.0.0 has been released last month and is now the version used by OpenBSD
-stable(7.6, which was released recently).This pull request simply disables this workaround when LibreSSL version is equal to, or greater than 4.0.0. In fact, it is just a copy from the patch introduced by Theo Buehler, from the OpenBSD project, when he updated the
net/i2pdport to the latest version : openbsd/ports@1757840