Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #13

Merged
merged 4 commits into from
Nov 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Node.js CI

on:
push:
branches: [ "master", "develop" ]
branches: [ "develop" ]
pull_request:
branches: [ "master" ]

Expand All @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
node-version: [19.x, 20.x, 21.x]
node-version: [20.x, 21.x, 22.x]

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -45,17 +45,15 @@ jobs:
- run: npm install
- run: npm run build

- name: Publish to npm dry-run
- name: Authenticate with npm
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
npm publish --dry-run
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ~/.npmrc

- name: Run npm publish dry run
run: npm run npm:publish:dry-run

- name: Publish to npm
if: github.ref == 'refs/heads/master' && github.event_name == 'push'
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
npm publish
run: npm run npm:publish
4 changes: 2 additions & 2 deletions docs/Controller.html

Large diffs are not rendered by default.

6,700 changes: 6,700 additions & 0 deletions docs/Facade.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/MacroCommand.html

Large diffs are not rendered by default.

18 changes: 14 additions & 4 deletions docs/Mediator.html

Large diffs are not rendered by default.

50 changes: 25 additions & 25 deletions docs/Model.html

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions docs/Notification.html

Large diffs are not rendered by default.

70 changes: 67 additions & 3 deletions docs/Notifier.html

Large diffs are not rendered by default.

49 changes: 44 additions & 5 deletions docs/Observer.html

Large diffs are not rendered by default.

26 changes: 21 additions & 5 deletions docs/Proxy.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/SimpleCommand.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/View.html

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/core_Controller.js.html

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/core_Model.js.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/core_View.js.html

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions docs/index.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/patterns_command_MacroCommand.js.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions docs/patterns_command_SimpleCommand.js.html

Large diffs are not rendered by default.

11 changes: 6 additions & 5 deletions docs/patterns_facade_Facade.js.html

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions docs/patterns_mediator_Mediator.js.html

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions docs/patterns_observer_Notification.js.html

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/patterns_observer_Notifier.js.html

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions docs/patterns_observer_Observer.js.html

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions docs/patterns_proxy_Proxy.js.html

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"babel-plugin-add-module-exports": "^1.0.4",
"babel-preset-env": "^0.0.0",
"chai": "^4.2.0",
"chromedriver": "^127.0.0",
"chromedriver": "^130.0.2",
"dotenv": "^16.0.3",
"edgedriver": "^5.3.8",
"geckodriver": "^4.2.1",
Expand Down
4 changes: 2 additions & 2 deletions src/patterns/observer/Notifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class Notifier {
constructor() {}

/**
* Create and send an `Notification`.
* Create and send a `Notification`.
*
* <P>Keeps us from having to construct new Notification
* instances in our implementation code.</P>
Expand Down Expand Up @@ -86,7 +86,7 @@ class Notifier {
/**
* Return the Multiton Facade instance
*
* @typedef {Facade} Facade
* @returns {Facade}
*
* @throws {Error}
*/
Expand Down
Loading