Merge pull request #13 from PureMVC/develop

Develop
PureMVC · Nov 2, 2024 · 531eb3a · 531eb3a
2 parents 145c150 + 84f145f
commit 531eb3a
Show file tree

Hide file tree

Showing 27 changed files with 6,965 additions and 135 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -2,7 +2,7 @@ name: Node.js CI
 
 on:
   push:
-    branches: [ "master", "develop" ]
+    branches: [ "develop" ]
   pull_request:
     branches: [ "master" ]
 
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [19.x, 20.x, 21.x]
+        node-version: [20.x, 21.x, 22.x]
 
     steps:
       - uses: actions/checkout@v3
@@ -45,17 +45,15 @@ jobs:
     - run: npm install
     - run: npm run build
 
-    - name: Publish to npm dry-run
+    - name: Authenticate with npm
       env:
-        NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-      run: |
-        echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
-        npm publish --dry-run
+        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+      run: echo "//registry.npmjs.org/:_authToken=${NODE_AUTH_TOKEN}" > ~/.npmrc
+
+    - name: Run npm publish dry run
+      run: npm run npm:publish:dry-run
 
     - name: Publish to npm
-      if: github.ref == 'refs/heads/master' && github.event_name == 'push'
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-      run: |
-        echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc
-        npm publish
+      run: npm run npm:publish
diff --git a/docs/Controller.html b/docs/Controller.html
diff --git a/docs/Facade.html b/docs/Facade.html
diff --git a/docs/MacroCommand.html b/docs/MacroCommand.html
diff --git a/docs/Mediator.html b/docs/Mediator.html
diff --git a/docs/Model.html b/docs/Model.html
diff --git a/docs/Notification.html b/docs/Notification.html
diff --git a/docs/Notifier.html b/docs/Notifier.html
diff --git a/docs/Observer.html b/docs/Observer.html
diff --git a/docs/Proxy.html b/docs/Proxy.html
diff --git a/docs/SimpleCommand.html b/docs/SimpleCommand.html
diff --git a/docs/View.html b/docs/View.html
diff --git a/docs/core_Controller.js.html b/docs/core_Controller.js.html
diff --git a/docs/core_Model.js.html b/docs/core_Model.js.html
diff --git a/docs/core_View.js.html b/docs/core_View.js.html
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/patterns_command_MacroCommand.js.html b/docs/patterns_command_MacroCommand.js.html
diff --git a/docs/patterns_command_SimpleCommand.js.html b/docs/patterns_command_SimpleCommand.js.html
diff --git a/docs/patterns_facade_Facade.js.html b/docs/patterns_facade_Facade.js.html
diff --git a/docs/patterns_mediator_Mediator.js.html b/docs/patterns_mediator_Mediator.js.html
diff --git a/docs/patterns_observer_Notification.js.html b/docs/patterns_observer_Notification.js.html
diff --git a/docs/patterns_observer_Notifier.js.html b/docs/patterns_observer_Notifier.js.html
diff --git a/docs/patterns_observer_Observer.js.html b/docs/patterns_observer_Observer.js.html
diff --git a/docs/patterns_proxy_Proxy.js.html b/docs/patterns_proxy_Proxy.js.html
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
     "babel-plugin-add-module-exports": "^1.0.4",
     "babel-preset-env": "^0.0.0",
     "chai": "^4.2.0",
-    "chromedriver": "^127.0.0",
+    "chromedriver": "^130.0.2",
     "dotenv": "^16.0.3",
     "edgedriver": "^5.3.8",
     "geckodriver": "^4.2.1",

diff --git a/src/patterns/observer/Notifier.js b/src/patterns/observer/Notifier.js
@@ -47,7 +47,7 @@ class Notifier {
     constructor() {}
 
     /**
-     * Create and send an `Notification`.
+     * Create and send a `Notification`.
      *
      * <P>Keeps us from having to construct new Notification
      * instances in our implementation code.</P>
@@ -86,7 +86,7 @@ class Notifier {
     /**
      * Return the Multiton Facade instance
      *
-     * @typedef {Facade} Facade
+     * @returns {Facade}
      *
      * @throws {Error}
      */