UOE-11757/UOE-11758: Changes for /geo endpoint with updated response
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue | ||
| } | ||
| //TO-DO keeping case-sensitive? | ||
| countryCodes[countryCode] = struct{}{} |
There was a problem hiding this comment.
Check with AdServer team about adding entry in table
Discussion to keeping this as only lower or upper case.
Also check whenever gdpr country table is updated we should get notified
| @@ -87,6 +89,8 @@ var initReloader = func(fe *feature) { | |||
| for { | |||
| //Populating feature config maps from cache | |||
| fe.updateFeatureConfigMaps() | |||
| //update gdprCountryCodes | |||
| fe.updateGDPRCountryCodes() | |||
There was a problem hiding this comment.
Create a separate task for customizing separate default expiry for different features
| func (fe *feature) IsCountryGDPREnabled(countryCode string) bool { | ||
| codes := fe.gdprCountryCodes.codes[fe.gdprCountryCodes.index] | ||
| _, enabled := codes[countryCode] | ||
| return enabled |
There was a problem hiding this comment.
define custom type for map[string]struct{}
| metricLabels.RequestStatus = prometheus.RequestStatusBadInput | ||
| return | ||
| } | ||
| pubIdStr = r.URL.Query().Get(models.PublisherID) |
There was a problem hiding this comment.
Do we really need to parse pubid from request? can we remove it?
There was a problem hiding this comment.
remove the error if possible
| return | ||
| } | ||
|
|
||
| ip := util.GetIP(r) |
There was a problem hiding this comment.
check IPs at Prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.