U0E-10990: Log error when a partial read of any DB Query.

modules/pubmatic/openwrap/beforevalidationhook.go

@@ -132,14 +132,9 @@ func (m OpenWrap) handleBeforeValidationHook(
 	if err != nil || len(partnerConfigMap) == 0 {
 		// TODO: seperate DB fetch errors as internal errors
 		result.NbrCode = int(nbr.InvalidProfileConfiguration)
-		if err != nil {
-			err = errors.New("failed to get profile data: " + err.Error())
-		} else {
-			err = errors.New("failed to get profile data: received empty data")
-		}
 		rCtx.ImpBidCtx = getDefaultImpBidCtx(*payload.BidRequest) // for wrapper logger sz
 		m.metricEngine.RecordPublisherInvalidProfileRequests(rCtx.Endpoint, rCtx.PubIDStr, rCtx.ProfileIDStr)
-		return result, err
+		return result, errors.New("invalid profile data")
 	}
 
 	if rCtx.IsCTVRequest && rCtx.Endpoint == models.EndpointJson {

modules/pubmatic/openwrap/beforevalidationhook_test.go

@@ -3858,7 +3858,7 @@ func TestOpenWrapHandleBeforeValidationHook(t *testing.T) {
 				hookResult: hookstage.HookResult[hookstage.BeforeValidationRequestPayload]{
 					Reject:  true,
 					NbrCode: int(nbr.InvalidProfileConfiguration),
-					Errors:  []string{"failed to get profile data: received empty data"},
+					Errors:  []string{"invalid profile data"},
 				},
 				error:                 true,
 				nilCurrencyConversion: true,

modules/pubmatic/openwrap/cache/gocache/adpod_config.go

@@ -1,19 +1,28 @@
 package gocache
 
 import (
+	"database/sql"
+	"errors"
 	"strconv"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adpodconfig"
 )
 
 func (c *cache) populateCacheWithAdpodConfig(pubID, profileID, displayVersion int) (err error) {
+	cacheKey := key(PubAdpodConfig, pubID, profileID, displayVersion)
 	adpodConfig, err := c.db.GetAdpodConfig(pubID, profileID, displayVersion)
 	if err != nil {
+		if errors.Is(err, sql.ErrNoRows) {
+			c.metricEngine.RecordDBQueryFailure(models.LiveVersionInnerQuery, strconv.Itoa(pubID), strconv.Itoa(profileID))
+		} else {
+			c.metricEngine.RecordDBQueryFailure(models.GetAdpodConfig, strconv.Itoa(pubID), strconv.Itoa(profileID))
+		}
+		glog.Errorf(models.ErrDBQueryFailed, models.GetAdpodConfig, pubID, profileID, err)
 		return err
 	}
 
-	cacheKey := key(PubAdpodConfig, pubID, profileID, displayVersion)
 	c.cache.Set(cacheKey, adpodConfig, getSeconds(c.cfg.CacheDefaultExpiry))
 	return
 }
@@ -32,7 +41,6 @@ func (c *cache) GetAdpodConfig(pubID, profileID, displayVersion int) (*adpodconf
 	if err := c.LockAndLoad(lockKey, func() error {
 		return c.populateCacheWithAdpodConfig(pubID, profileID, displayVersion)
 	}); err != nil {
-		c.metricEngine.RecordDBQueryFailure(models.GetAdpodConfig, strconv.Itoa(pubID), strconv.Itoa(profileID))
 		return nil, err
 	}
 

modules/pubmatic/openwrap/cache/gocache/app_integration_path.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetAppIntegrationPaths() (map[string]int, error) {
 	appIntegrationPathMap, err := c.db.GetAppIntegrationPaths()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AppIntegrationPathMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AppIntegrationPathMapQuery, "", "", err)
 		return appIntegrationPathMap, fmt.Errorf(errorAppIntegrationPathMapUpdate, err)
 	}
 	return appIntegrationPathMap, nil

modules/pubmatic/openwrap/cache/gocache/app_sub_integartion_path.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetAppSubIntegrationPaths() (map[string]int, error) {
 	appSubIntegrationPathMap, err := c.db.GetAppSubIntegrationPaths()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AppSubIntegrationPathMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AppSubIntegrationPathMapQuery, "", "", err)
 		return appSubIntegrationPathMap, fmt.Errorf(errorAppSubIntegrationPathMapUpdate, err)
 	}
 	return appSubIntegrationPathMap, nil

modules/pubmatic/openwrap/cache/gocache/fullscreenclickability.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -15,6 +16,7 @@ func (c *cache) GetFSCThresholdPerDSP() (map[int]int, error) {
 	fscThreshold, err := c.db.GetFSCThresholdPerDSP()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AllDspFscPcntQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AllDspFscPcntQuery, "", "", err)
 		return fscThreshold, fmt.Errorf(errorFscDspMsg, err)
 	}
 	return fscThreshold, nil

modules/pubmatic/openwrap/cache/gocache/partner_config.go

@@ -1,11 +1,13 @@
 package gocache
 
 import (
+	"database/sql"
 	"errors"
 	"fmt"
 	"strconv"
 	"time"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adunitconfig"
 )
@@ -67,13 +69,19 @@ func (c *cache) getActivePartnerConfigAndPopulateWrapperMappings(pubID, profileI
 	cacheKey := key(PUB_HB_PARTNER, pubID, profileID, displayVersion)
 	partnerConfigMap, err := c.db.GetActivePartnerConfigurations(pubID, profileID, displayVersion)
 	if err != nil {
-		c.metricEngine.RecordDBQueryFailure(models.PartnerConfigQuery, strconv.Itoa(pubID), strconv.Itoa(profileID))
-		return
+		if errors.Is(err, sql.ErrNoRows) {
+			c.metricEngine.RecordDBQueryFailure(models.LiveVersionInnerQuery, strconv.Itoa(pubID), strconv.Itoa(profileID))
+			c.cache.Set(cacheKey, partnerConfigMap, getSeconds(c.cfg.CacheDefaultExpiry))
+		} else {
+			c.metricEngine.RecordDBQueryFailure(models.PartnerConfigQuery, strconv.Itoa(pubID), strconv.Itoa(profileID))
+		}
+		glog.Errorf(models.ErrDBQueryFailed, models.PartnerConfigQuery, pubID, profileID, err)
+		return err
 	}
 
 	if len(partnerConfigMap) == 0 {
 		c.cache.Set(cacheKey, partnerConfigMap, getSeconds(c.cfg.CacheDefaultExpiry))
-		return fmt.Errorf("there are no active partners for pubId:%d, profileId:%d, displayVersion:%d", pubID, profileID, displayVersion)
+		return fmt.Errorf(models.EmptyPartnerConfig, pubID, profileID, displayVersion)
 	}
 
 	err = c.populateCacheWithWrapperSlotMappings(pubID, partnerConfigMap, profileID, displayVersion)
@@ -83,6 +91,7 @@ func (c *cache) getActivePartnerConfigAndPopulateWrapperMappings(pubID, profileI
 			queryType = models.WrapperLiveVersionSlotMappings
 		}
 		c.metricEngine.RecordDBQueryFailure(queryType, strconv.Itoa(pubID), strconv.Itoa(profileID))
+		glog.Errorf(models.ErrDBQueryFailed, queryType, pubID, profileID, err)
 		return err
 	}
 
@@ -96,6 +105,7 @@ func (c *cache) getActivePartnerConfigAndPopulateWrapperMappings(pubID, profileI
 			queryType = models.AdUnitFailUnmarshal
 		}
 		c.metricEngine.RecordDBQueryFailure(queryType, strconv.Itoa(pubID), strconv.Itoa(profileID))
+		glog.Errorf(models.ErrDBQueryFailed, queryType, pubID, profileID, err)
 		return err
 	}
 

modules/pubmatic/openwrap/cache/gocache/profile_type_platform.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetProfileTypePlatforms() (map[string]int, error) {
 	profileTypePlatformMap, err := c.db.GetProfileTypePlatforms()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.ProfileTypePlatformMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.ProfileTypePlatformMapQuery, "", "", err)
 		return profileTypePlatformMap, fmt.Errorf(errorProfileTypePlatformMapUpdate, err)
 	}
 	return profileTypePlatformMap, nil

modules/pubmatic/openwrap/cache/gocache/publisher_feature.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetPublisherFeatureMap() (map[int]map[int]models.FeatureData, er
 	publisherFeatureMap, err := c.db.GetPublisherFeatureMap()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.PublisherFeatureMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.PublisherFeatureMapQuery, "", "", err)
 		return publisherFeatureMap, fmt.Errorf(errorPubFeatureUpdate, err)
 	}
 	return publisherFeatureMap, nil

modules/pubmatic/openwrap/cache/gocache/slot_mappings.go

@@ -6,6 +6,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/openrtb_ext"
 )
@@ -15,6 +16,10 @@ func (c *cache) populateCacheWithPubSlotNameHash(pubID int) (err error) {
 	cacheKey := key(PubSlotNameHash, pubID)
 
 	publisherSlotNameHashMap, err := c.db.GetPublisherSlotNameHash(pubID)
+	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.SlotNameHash, pubID, "", err)
+		return
+	}
 	//This call may set nil publisherSlotNameHashMap in cache
 	c.cache.Set(cacheKey, publisherSlotNameHashMap, getSeconds(c.cfg.CacheDefaultExpiry))
 	return
@@ -23,6 +28,9 @@ func (c *cache) populateCacheWithPubSlotNameHash(pubID int) (err error) {
 // PopulateCacheWithWrapperSlotMappings will get the SlotMappings from database and put them in cache.
 func (c *cache) populateCacheWithWrapperSlotMappings(pubID int, partnerConfigMap map[int]map[string]string, profileID, displayVersion int) error {
 	partnerSlotMappingMap, err := c.db.GetWrapperSlotMappings(partnerConfigMap, profileID, displayVersion)
+	if err != nil {
+		return err
+	}
 
 	//put a version level dummy entry in cache denoting mappings are present for this version
 	cacheKey := key(PUB_SLOT_INFO, pubID, profileID, displayVersion, 0)

modules/pubmatic/openwrap/cache/gocache/slot_mappings_test.go

@@ -41,8 +41,9 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 		pubid int
 	}
 	type want struct {
-		publisherSlotNameHashMap map[string]string
+		publisherSlotNameHashMap interface{}
 		err                      error
+		foundCacheKey            bool
 	}
 	tests := []struct {
 		name   string
@@ -69,6 +70,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 			want: want{
 				publisherSlotNameHashMap: nil,
 				err:                      fmt.Errorf("Error from the DB"),
+				foundCacheKey:            false,
 			},
 		},
 		{
@@ -93,6 +95,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 				publisherSlotNameHashMap: map[string]string{
 					testSlotName: testHashValue,
 				},
+				foundCacheKey: true,
 			},
 		},
 		{
@@ -111,8 +114,9 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 				mockDatabase.EXPECT().GetPublisherSlotNameHash(5890).Return(nil, nil)
 			},
 			want: want{
-				publisherSlotNameHashMap: nil,
+				publisherSlotNameHashMap: map[string]string(nil),
 				err:                      nil,
+				foundCacheKey:            true,
 			},
 		},
 	}
@@ -131,7 +135,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 			assert.Equal(t, tt.want.err, err)
 			cacheKey := key(PubSlotNameHash, tt.args.pubid)
 			publisherSlotNameHashMap, found := c.cache.Get(cacheKey)
-			assert.True(t, found)
+			assert.Equal(t, tt.want.foundCacheKey, found)
 			assert.Equal(t, tt.want.publisherSlotNameHashMap, publisherSlotNameHashMap)
 		})
 	}
@@ -157,8 +161,9 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 		displayVersion   int
 	}
 	type want struct {
-		partnerSlotMapping map[string]models.SlotMapping
+		partnerSlotMapping interface{}
 		err                error
+		foundCacheKey      bool
 	}
 	tests := []struct {
 		name   string
@@ -186,8 +191,9 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 				mockDatabase.EXPECT().GetWrapperSlotMappings(formTestPartnerConfig(), testProfileID, testVersionID).Return(nil, fmt.Errorf("Error from the DB"))
 			},
 			want: want{
-				partnerSlotMapping: map[string]models.SlotMapping{},
+				partnerSlotMapping: nil,
 				err:                fmt.Errorf("Error from the DB"),
+				foundCacheKey:      false,
 			},
 		},
 		{
@@ -211,6 +217,7 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 			want: want{
 				partnerSlotMapping: map[string]models.SlotMapping{},
 				err:                nil,
+				foundCacheKey:      true,
 			},
 		},
 		{
@@ -261,7 +268,8 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 						OrderID: 0,
 					},
 				},
-				err: nil,
+				err:           nil,
+				foundCacheKey: true,
 			},
 		},
 		{
@@ -295,7 +303,8 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 				}, nil)
 			},
 			want: want{
-				err: nil,
+				err:           nil,
+				foundCacheKey: true,
 				partnerSlotMapping: map[string]models.SlotMapping{
 					"adunit@300x250": {
 						PartnerId:   testPartnerID,
@@ -331,7 +340,7 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 
 			cacheKey := key(PUB_SLOT_INFO, tt.args.pubid, tt.args.profileId, tt.args.displayVersion, testPartnerID)
 			partnerSlotMapping, found := c.cache.Get(cacheKey)
-			assert.True(t, found)
+			assert.Equal(t, tt.want.foundCacheKey, found)
 			assert.Equal(t, tt.want.partnerSlotMapping, partnerSlotMapping)
 
 		})

modules/pubmatic/openwrap/cache/gocache/vast_tags.go

@@ -1,6 +1,7 @@
 package gocache
 
 import (
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -11,13 +12,10 @@ func (c *cache) populatePublisherVASTTags(pubID int) error {
 	//get publisher level vast tag details from DB
 	publisherVASTTags, err := c.db.GetPublisherVASTTags(pubID)
 	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.PublisherVASTTagsQuery, pubID, "", err)
 		return err
 	}
 
-	if publisherVASTTags == nil {
-		publisherVASTTags = models.PublisherVASTTags{}
-	}
-
 	c.cache.Set(cacheKey, publisherVASTTags, getSeconds(c.cfg.VASTTagCacheExpiry))
 	return nil
 }

modules/pubmatic/openwrap/cache/gocache/vast_tags_test.go

@@ -111,7 +111,7 @@ func Test_cache_populatePublisherVASTTags(t *testing.T) {
 			want: want{
 				cacheEntry:        true,
 				err:               nil,
-				PublisherVASTTags: models.PublisherVASTTags{},
+				PublisherVASTTags: models.PublisherVASTTags(nil),
 			},
 		},
 	}