U0E-10990: Log error when a partial read of any DB Query.

modules/pubmatic/openwrap/cache/gocache/adpod_config.go

@@ -3,13 +3,15 @@ package gocache
 import (
 	"strconv"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adpodconfig"
 )
 
 func (c *cache) populateCacheWithAdpodConfig(pubID, profileID, displayVersion int) (err error) {
 	adpodConfig, err := c.db.GetAdpodConfig(pubID, profileID, displayVersion)
 	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.GetAdpodConfig, pubID, profileID, err)
 		return err
 	}
 

modules/pubmatic/openwrap/cache/gocache/adunit_config.go

@@ -3,13 +3,16 @@ package gocache
 import (
 	"strings"
 
+	"github.com/golang/glog"
 	"github.com/prebid/openrtb/v20/openrtb2"
+	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adunitconfig"
 )
 
 func (c *cache) populateCacheWithAdunitConfig(pubID int, profileID, displayVersion int) (err error) {
 	adunitConfig, err := c.db.GetAdunitConfig(profileID, displayVersion)
 	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.AdunitConfigQuery, pubID, profileID, err)
 		return err
 	}
 

modules/pubmatic/openwrap/cache/gocache/app_integration_path.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetAppIntegrationPaths() (map[string]int, error) {
 	appIntegrationPathMap, err := c.db.GetAppIntegrationPaths()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AppIntegrationPathMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AppIntegrationPathMapQuery, "", "", err)
 		return appIntegrationPathMap, fmt.Errorf(errorAppIntegrationPathMapUpdate, err)
 	}
 	return appIntegrationPathMap, nil

modules/pubmatic/openwrap/cache/gocache/app_sub_integartion_path.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetAppSubIntegrationPaths() (map[string]int, error) {
 	appSubIntegrationPathMap, err := c.db.GetAppSubIntegrationPaths()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AppSubIntegrationPathMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AppSubIntegrationPathMapQuery, "", "", err)
 		return appSubIntegrationPathMap, fmt.Errorf(errorAppSubIntegrationPathMapUpdate, err)
 	}
 	return appSubIntegrationPathMap, nil

modules/pubmatic/openwrap/cache/gocache/fullscreenclickability.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -15,6 +16,7 @@ func (c *cache) GetFSCThresholdPerDSP() (map[int]int, error) {
 	fscThreshold, err := c.db.GetFSCThresholdPerDSP()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.AllDspFscPcntQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.AllDspFscPcntQuery, "", "", err)
 		return fscThreshold, fmt.Errorf(errorFscDspMsg, err)
 	}
 	return fscThreshold, nil

modules/pubmatic/openwrap/cache/gocache/partner_config.go

@@ -1,11 +1,13 @@
 package gocache
 
 import (
+	"database/sql"
 	"errors"
 	"fmt"
 	"strconv"
 	"time"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adunitconfig"
 )
@@ -67,8 +69,13 @@ func (c *cache) getActivePartnerConfigAndPopulateWrapperMappings(pubID, profileI
 	cacheKey := key(PUB_HB_PARTNER, pubID, profileID, displayVersion)
 	partnerConfigMap, err := c.db.GetActivePartnerConfigurations(pubID, profileID, displayVersion)
 	if err != nil {
+		if errors.Is(err, sql.ErrNoRows) {
+			c.cache.Set(cacheKey, partnerConfigMap, getSeconds(c.cfg.CacheDefaultExpiry))
+			glog.Errorf("No rows found for partner config query for pubID %d, profileID %d: %v", pubID, profileID, err)
+		}
 		c.metricEngine.RecordDBQueryFailure(models.PartnerConfigQuery, strconv.Itoa(pubID), strconv.Itoa(profileID))
-		return
+		glog.Errorf(models.ErrDBQueryFailed, models.PartnerConfigQuery, pubID, profileID, err)
+		return err
 	}
 
 	if len(partnerConfigMap) == 0 {

modules/pubmatic/openwrap/cache/gocache/profile_type_platform.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetProfileTypePlatforms() (map[string]int, error) {
 	profileTypePlatformMap, err := c.db.GetProfileTypePlatforms()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.ProfileTypePlatformMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.ProfileTypePlatformMapQuery, "", "", err)
 		return profileTypePlatformMap, fmt.Errorf(errorProfileTypePlatformMapUpdate, err)
 	}
 	return profileTypePlatformMap, nil

modules/pubmatic/openwrap/cache/gocache/publisher_feature.go

@@ -3,6 +3,7 @@ package gocache
 import (
 	"fmt"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -13,6 +14,7 @@ func (c *cache) GetPublisherFeatureMap() (map[int]map[int]models.FeatureData, er
 	publisherFeatureMap, err := c.db.GetPublisherFeatureMap()
 	if err != nil {
 		c.metricEngine.RecordDBQueryFailure(models.PublisherFeatureMapQuery, "", "")
+		glog.Errorf(models.ErrDBQueryFailed, models.PublisherFeatureMapQuery, "", "", err)
 		return publisherFeatureMap, fmt.Errorf(errorPubFeatureUpdate, err)
 	}
 	return publisherFeatureMap, nil

modules/pubmatic/openwrap/cache/gocache/slot_mappings.go

@@ -6,6 +6,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/openrtb_ext"
 )
@@ -15,6 +16,10 @@ func (c *cache) populateCacheWithPubSlotNameHash(pubID int) (err error) {
 	cacheKey := key(PubSlotNameHash, pubID)
 
 	publisherSlotNameHashMap, err := c.db.GetPublisherSlotNameHash(pubID)
+	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.SlotNameHash, pubID, "", err)
+		return err
+	}
 	//This call may set nil publisherSlotNameHashMap in cache
 	c.cache.Set(cacheKey, publisherSlotNameHashMap, getSeconds(c.cfg.CacheDefaultExpiry))
 	return
@@ -23,6 +28,10 @@ func (c *cache) populateCacheWithPubSlotNameHash(pubID int) (err error) {
 // PopulateCacheWithWrapperSlotMappings will get the SlotMappings from database and put them in cache.
 func (c *cache) populateCacheWithWrapperSlotMappings(pubID int, partnerConfigMap map[int]map[string]string, profileID, displayVersion int) error {
 	partnerSlotMappingMap, err := c.db.GetWrapperSlotMappings(partnerConfigMap, profileID, displayVersion)
+	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.WrapperSlotMappingsQuery+"/"+models.WrapperLiveVersionSlotMappings, pubID, profileID, err)
+		return err
+	}
 
 	//put a version level dummy entry in cache denoting mappings are present for this version
 	cacheKey := key(PUB_SLOT_INFO, pubID, profileID, displayVersion, 0)

modules/pubmatic/openwrap/cache/gocache/slot_mappings_test.go

@@ -41,8 +41,9 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 		pubid int
 	}
 	type want struct {
-		publisherSlotNameHashMap map[string]string
+		publisherSlotNameHashMap interface{}
 		err                      error
+		foundCacheKey            bool
 	}
 	tests := []struct {
 		name   string
@@ -69,6 +70,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 			want: want{
 				publisherSlotNameHashMap: nil,
 				err:                      fmt.Errorf("Error from the DB"),
+				foundCacheKey:            false,
 			},
 		},
 		{
@@ -93,6 +95,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 				publisherSlotNameHashMap: map[string]string{
 					testSlotName: testHashValue,
 				},
+				foundCacheKey: true,
 			},
 		},
 		{
@@ -111,8 +114,9 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 				mockDatabase.EXPECT().GetPublisherSlotNameHash(5890).Return(nil, nil)
 			},
 			want: want{
-				publisherSlotNameHashMap: nil,
+				publisherSlotNameHashMap: map[string]string(nil),
 				err:                      nil,
+				foundCacheKey:            true,
 			},
 		},
 	}
@@ -131,7 +135,7 @@ func Test_cache_populateCacheWithPubSlotNameHash(t *testing.T) {
 			assert.Equal(t, tt.want.err, err)
 			cacheKey := key(PubSlotNameHash, tt.args.pubid)
 			publisherSlotNameHashMap, found := c.cache.Get(cacheKey)
-			assert.True(t, found)
+			assert.Equal(t, tt.want.foundCacheKey, found)
 			assert.Equal(t, tt.want.publisherSlotNameHashMap, publisherSlotNameHashMap)
 		})
 	}
@@ -157,8 +161,9 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 		displayVersion   int
 	}
 	type want struct {
-		partnerSlotMapping map[string]models.SlotMapping
+		partnerSlotMapping interface{}
 		err                error
+		foundCacheKey      bool
 	}
 	tests := []struct {
 		name   string
@@ -186,8 +191,9 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 				mockDatabase.EXPECT().GetWrapperSlotMappings(formTestPartnerConfig(), testProfileID, testVersionID).Return(nil, fmt.Errorf("Error from the DB"))
 			},
 			want: want{
-				partnerSlotMapping: map[string]models.SlotMapping{},
+				partnerSlotMapping: nil,
 				err:                fmt.Errorf("Error from the DB"),
+				foundCacheKey:      false,
 			},
 		},
 		{
@@ -211,6 +217,7 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 			want: want{
 				partnerSlotMapping: map[string]models.SlotMapping{},
 				err:                nil,
+				foundCacheKey:      true,
 			},
 		},
 		{
@@ -261,7 +268,8 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 						OrderID: 0,
 					},
 				},
-				err: nil,
+				err:           nil,
+				foundCacheKey: true,
 			},
 		},
 		{
@@ -295,7 +303,8 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 				}, nil)
 			},
 			want: want{
-				err: nil,
+				err:           nil,
+				foundCacheKey: true,
 				partnerSlotMapping: map[string]models.SlotMapping{
 					"adunit@300x250": {
 						PartnerId:   testPartnerID,
@@ -331,7 +340,7 @@ func Test_cache_populateCacheWithWrapperSlotMappings(t *testing.T) {
 
 			cacheKey := key(PUB_SLOT_INFO, tt.args.pubid, tt.args.profileId, tt.args.displayVersion, testPartnerID)
 			partnerSlotMapping, found := c.cache.Get(cacheKey)
-			assert.True(t, found)
+			assert.Equal(t, tt.want.foundCacheKey, found)
 			assert.Equal(t, tt.want.partnerSlotMapping, partnerSlotMapping)
 
 		})

modules/pubmatic/openwrap/cache/gocache/vast_tags.go

@@ -1,6 +1,7 @@
 package gocache
 
 import (
+	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
@@ -11,6 +12,7 @@ func (c *cache) populatePublisherVASTTags(pubID int) error {
 	//get publisher level vast tag details from DB
 	publisherVASTTags, err := c.db.GetPublisherVASTTags(pubID)
 	if err != nil {
+		glog.Errorf(models.ErrDBQueryFailed, models.PublisherVASTTagsQuery, pubID, "", err)
 		return err
 	}
 

modules/pubmatic/openwrap/database/mysql/adpod_config.go

@@ -3,26 +3,26 @@ package mysql
 import (
 	"context"
 	"encoding/json"
+	"fmt"
 	"strings"
 	"time"
 
-	"github.com/golang/glog"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/adpodconfig"
 )
 
 func (db *mySqlDB) GetAdpodConfig(pubID, profileID, displayVersion int) (*adpodconfig.AdpodConfig, error) {
 	versionID, displayVersion, _, _, err := db.getVersionIdAndProfileDetails(profileID, displayVersion, pubID)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("LiveVersionInnerQuery/DisplayVersionInnerQuery Failure Error: %w", err)
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Duration(time.Millisecond*time.Duration(db.cfg.MaxDbContextTimeout)))
 	defer cancel()
 
 	rows, err := db.conn.QueryContext(ctx, db.cfg.Queries.GetAdpodConfig, versionID)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("GetAdpodConfigQuery Failure Error: %w", err)
 	}
 	defer rows.Close()
 
@@ -49,12 +49,12 @@ func (db *mySqlDB) GetAdpodConfig(pubID, profileID, displayVersion int) (*adpodc
 		}
 
 		if err != nil {
-			return nil, err
+			return nil, fmt.Errorf("Unmarshal Error: %w", err)
 		}
 	}
 
 	if err = rows.Err(); err != nil {
-		glog.Errorf("adpod config row scan failed for publisher %d having profile %d with versionID %d", pubID, profileID, displayVersion)
+		return nil, fmt.Errorf("Row scan Failure Error: %w", err)
 	}
 
 	return config, nil