Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-1768: Set logger parameters for VMAP, so that we can use it for reporting #835

Open
wants to merge 21 commits into
base: ci
Choose a base branch
from
Open

OTT-1768: Set logger parameters for VMAP, so that we can use it for reporting #835

wants to merge 21 commits into from

Conversation

Pubmatic-Supriya-Patil
Copy link
Collaborator

…eporting

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

ashishshinde-pubm
ashishshinde-pubm requested changes Jul 8, 2024
View reviewed changes
endpoints/openrtb2/ctv/adpod/util.go Show resolved Hide resolved
endpoints/openrtb2/ctv/adpod/structured_adpod.go Outdated Show resolved Hide resolved
endpoints/openrtb2/ctv_auction.go Show resolved Hide resolved
endpoints/openrtb2/ctv_auction_test.go Outdated Show resolved Hide resolved
openrtb_ext/bid.go Show resolved Hide resolved
endpoints/openrtb2/ctv/adpod/adpod.go Outdated Show resolved Hide resolved
pm-nikhil-vaidya
pm-nikhil-vaidya requested changes Jul 8, 2024
View reviewed changes
endpoints/openrtb2/ctv_auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/ctv_auction.go Outdated Show resolved Hide resolved
endpoints/openrtb2/ctv_auction.go Show resolved Hide resolved
endpoints/openrtb2/ctv_auction.go Outdated Show resolved Hide resolved
@ashishshinde-pubm ashishshinde-pubm self-requested a review July 9, 2024 12:10
@ashishshinde-pubm ashishshinde-pubm self-requested a review July 10, 2024 04:52
ShriprasadM
ShriprasadM requested changes Jul 17, 2024
View reviewed changes
endpoints/openrtb2/ctv/adpod/adpod.go Show resolved Hide resolved
endpoints/openrtb2/ctv/adpod/adpod.go Outdated Show resolved Hide resolved
endpoints/openrtb2/ctv/adpod/dynamic_adpod.go Outdated Show resolved Hide resolved
@ShriprasadM ShriprasadM self-requested a review July 19, 2024 08:40
ShriprasadM
ShriprasadM previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@ShriprasadM ShriprasadM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pm-priyanka-bagade and others added 2 commits August 30, 2024 17:19
@pm-priyanka-bagade
UOE-10950 : kgpv and kgpsv getting empty in logger for flag test=1 (#877
8a1de80 
)

* updated kgpv for regex

* added test cases

* resolved comments

* added test cases

* changed adslot logic for testvalue=2

* check for empty kgpv in logger

* resolved review comments
@Pubmatic-Supriya-Patil
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
9e3eb05 
…OTT-1768
@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil changed the base branch from ci_backup_20240824 to ci September 2, 2024 05:21
@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil dismissed ashishshinde-pubm’s stale review September 26, 2024 12:19

The merge-base changed after approval.

@pm-viral-vala pm-viral-vala force-pushed the ci branch 2 times, most recently from 1eadcd8 to bcc32d1 Compare September 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-nikhil-vaidya pm-nikhil-vaidya pm-nikhil-vaidya requested changes

@ashishshinde-pubm ashishshinde-pubm ashishshinde-pubm left review comments

@ShriprasadM ShriprasadM ShriprasadM left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pubmatic-Supriya-Patil @ShriprasadM @pm-nikhil-vaidya @ashishshinde-pubm @AvinashKapre @pm-priyanka-bagade