UOE-11484: fixing invalid vast xml for spaces in pricing node (#954)

PubMatic-OpenWrap · Nov 7, 2024 · 1fb78f7 · 1fb78f7
1 parent b9681b8
commit 1fb78f7
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/adapters/vastbidder/etree_parser_test.go b/adapters/vastbidder/etree_parser_test.go
@@ -330,6 +330,12 @@ func getPricingDetailsTestCases() []struct {
 			wantPrice:    12.05,
 			wantCurrency: "USD",
 		},
+		{
+			name:         "vast_with_whitespace_cdata_pricing",
+			vastXML:      `<VAST version="3.0"><Ad><Wrapper><Pricing>  <![CDATA[ 12.05 ]]>  </Pricing></Wrapper></Ad></VAST>`,
+			wantPrice:    12.05,
+			wantCurrency: "USD",
+		},
 		{
 			name:         "vast_gt_2.x_pricing",
 			vastXML:      `<VAST version="3.0"><Ad><Wrapper><Pricing>12.05</Pricing></Wrapper></Ad></VAST>`,

diff --git a/modules/pubmatic/openwrap/tracker/video.go b/modules/pubmatic/openwrap/tracker/video.go
@@ -128,7 +128,7 @@ func InjectPricingNodeInVAST(parent *etree.Element, price float64, model string,
 
 func updatePricingNode(node *etree.Element, price float64, model string, currency string) {
 	//Update Price
-
+	node.Child = nil
 	node.SetText(fmt.Sprintf("%v", price))
 
 	//Update Pricing.Model

diff --git a/modules/pubmatic/openwrap/tracker/video_test.go b/modules/pubmatic/openwrap/tracker/video_test.go
@@ -701,6 +701,26 @@ func Test_updatePricingNode(t *testing.T) {
 			},
 			want: `<Pricing model="` + models.VideoPricingModelCPM + `" currency="` + models.VideoPricingCurrencyUSD + `"><![CDATA[1.2]]></Pricing>`,
 		},
+		{
+			name: "adding_space_in_price",
+			args: args{
+				doc:      getXMLDocument(`<Pricing>  4.5  </Pricing>`),
+				price:    1.2,
+				model:    "",
+				currency: "",
+			},
+			want: `<Pricing model="` + models.VideoPricingModelCPM + `" currency="` + models.VideoPricingCurrencyUSD + `"><![CDATA[1.2]]></Pricing>`,
+		},
+		{
+			name: "adding_space_in_price_with_cdata",
+			args: args{
+				doc:      getXMLDocument(`<Pricing>  <![CDATA[4.5]]>  </Pricing>`),
+				price:    1.2,
+				model:    "",
+				currency: "",
+			},
+			want: `<Pricing model="` + models.VideoPricingModelCPM + `" currency="` + models.VideoPricingCurrencyUSD + `"><![CDATA[1.2]]></Pricing>`,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {