Refactor blob detection outside of the Touch class #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace some hard-coded variables by a maxNumBlobs variable - Directly return a movement vector from the blob detector, so client code doesn't have to store previous blob positions - everything needs to be thoroughly tested
3 tasks
jcelerier
reviewed
Dec 17, 2024
edumeneses
reviewed
Dec 17, 2024
There was a problem hiding this comment.
We may leave this as is for now, but my suggestion is to have the blobdetector as a separate class and the touch class only dealing with extracting the features.
In that case, there's no need for multi versions of the gestures as the class itself will deal with 1 DoF at a time. The user can implement multi versions (or we can create wrappers for that) from the main touch class.
include/puara/descriptors/touch.h
Outdated
|
|
||
| // brush: direction and intensity of capsense brush motion | ||
| // rub: intensity of rub motion | ||
| // in ~cm/s (distance between stripes = ~1.5cm) | ||
| for(int i = 0; i < (sizeof(blobPos) / sizeof(blobPos[0])); ++i) | ||
| for(int i = 0; i < maxNumBlobs; ++i) |
There was a problem hiding this comment.
I think we can remove the iteration and simplify the class to process a single DoF
Comment on lines
+96
to
+97
| multiBrush[i] = multiBrushIntegrator[i].integrate(movement[i] * 0.15); | ||
| multiRub[i] = multiRubIntegrator[i].integrate(std::abs(movement[i] * 0.15)); |
There was a problem hiding this comment.
Here we can promote brush and rub as specific classes (separate from the less interesting gestures from this class)
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18.
Touchclass and into its own class,BlobDetectortesting_touch.cppto