Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Touch to a single DoF class #23

Open
jcelerier opened this issue Dec 20, 2024 · 2 comments · May be fixed by #26
Open

Simplify Touch to a single DoF class #23

jcelerier opened this issue Dec 20, 2024 · 2 comments · May be fixed by #26
Assignees
@vberthiaume

Comments

@jcelerier
Copy link
Collaborator 

          I think we can remove the iteration and simplify the class to process a single DoF

Originally posted by @edumeneses in #20 (comment)
@jcelerier
Copy link
Collaborator Author

Not 100% sure if this has been done or not in the previous PR, just putting this here to make sure we wouldn't forget about it !

@vberthiaume
Copy link
Member

vberthiaume commented Dec 20, 2024 •
edited
Loading

ah yep perfect thank you! It hasn't been done but is my next step 🚀

@vberthiaume vberthiaume self-assigned this Dec 20, 2024
@vberthiaume vberthiaume linked a pull request Jan 8, 2025 that will close this issue
Open
@vberthiaume vberthiaume linked a pull request Jan 8, 2025 that will close this issue
Refactor Touch class to extract Brush and Rub classes as their own touch features #26
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vberthiaume vberthiaume

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jcelerier @vberthiaume