Delimiter and http only support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psibean
force-pushed
the
delimiter-and-http-only-support
branch
from
4939872 to
6d1e87b
Compare
When storing the value in the cookie both the non-hashed token and the hashed token are concatenated together separated by a delimiter. This is so that stateless re-use of the token value can be supported. Previously the delimiter was hardcoded to a '|' character, this can now be overridden via the delimiter configuration option.
Technically there's nothing wrong with disabling the httpOnly option for the csrf cookie. It's a valid way for the frontend to also extract the token value to then include it in a header or request body, many other CSRF solutions allow this. Due to some controversial discussions around a particular use case where Twitter had a CSRF vulnerability from a vulnerable subdomain. The httpOnly option being set to true could have mitigated the vulnerability in that particular case. Because of this, csrf-csrf enforced a httpOnly flag of true. However, it should be up to the developer to determine the risk involved and whether or not that's the implementation they want to use. csrf-csrf will default to httpOnly true and will continue to recommend keeping it as true, but will not restrict the choice to balance their security as they feel fit.
psibean
force-pushed
the
delimiter-and-http-only-support
branch
from
6d1e87b to
dd8d51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the v4 major version release is taking a bit longer than I'd expected, here's a slight update for v3, no breaking changes.