Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/allow multiple secrets #37

Merged
merged 16 commits into from
Nov 5, 2023
Merged

Feat/allow multiple secrets #37

merged 16 commits into from
Nov 5, 2023

Conversation

psibean
Copy link
Contributor

@psibean psibean commented Oct 30, 2023 •
edited
Loading

To address #34

psibean
psibean commented Oct 30, 2023
View reviewed changes
Copy link
Contributor Author

@psibean psibean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Haven't tested it myself directly but the tests look pretty solid.

src/tests/testsuite.ts Outdated Show resolved Hide resolved
src/tests/testsuite.ts Outdated Show resolved Hide resolved
src/tests/doublecsrf.test.ts Show resolved Hide resolved
@psibean
Copy link
Contributor Author

psibean commented Oct 30, 2023

Logic is pretty sound, README update is definitely needed

@davidgonmar davidgonmar self-requested a review October 31, 2023 19:57
davidgonmar
davidgonmar previously approved these changes Nov 1, 2023
View reviewed changes
psibean
psibean commented Nov 5, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@psibean psibean merged commit 51da818 into main Nov 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgonmar davidgonmar davidgonmar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psibean @davidgonmar