fix: /help, /me, and /p commands can't work in non-English languages

[ACaiCat]

When TShock runs in a non-English language, vanilla commands prefix will be localized.

eg.(Chinese) /help (English command prefix) => /帮助 (Chinese command prefix)

TShock.OnChat cannot correctly handle vanilla command prefixes

e.g.(Chinese) When a player use /help, TShock will execute /帮助 (causing the command to not be found).

Invalid command entered. Type /help for a list of valid commands.

This PR add EnglishLanguage.GetCommandPrefixByName to get English vanilla command prefix.

[ACaiCat]

Solve #2914

[ACaiCat]

Could someone review this PR?

[hakusaro]

Can someone else look at this too?

[sgkoishi]

This is requesting the enUS locale as set earlier

TShock/TShockAPI/Localization/EnglishLanguage.cs

Line 50 in 0b6bf9e

LanguageManager.Instance.SetLanguage(GameCulture.FromCultureName(GameCulture.CultureName.English));

I guess the Clear was done for similar reason like my implementation (but I did set the _localizedCommands back after)
https://github.com/sgkoishi/yaaiomni/blob/debf82951dd84bd307fc7bce06a1c03160479976/Core/Enhancements.cs#L129

[bartico6]

Can someone else look at this too?

I would, but I don't understand the issue very well.. Can you ELI5 what is wrong?

[sgkoishi]

Can someone else look at this too?

I would, but I don't understand the issue very well.. Can you ELI5 what is wrong?

Terraria will translate chat commands into command id. TShock translate them back to keep the command working.
However, when the server and the client have different locale, a enUS player send /help will be sent as CommandId: Help and a deDE server will translate it back to /hilfe, thus the command is broken.

[Arthri]

Tested and can confirm that it works as intended