Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix futures #28469

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fix futures #28469

merged 3 commits into from
Dec 16, 2024

Conversation

mikebenfield
Copy link
Collaborator

No description provided.

@mikebenfield mikebenfield requested a review from d0cd December 3, 2024 19:21
d0cd
d0cd reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some nits and comments.
Any chance this approach can be used to address either of these issues:

I believe the CI failure is due to some expectations that need to be regenerated

Cargo.lock Outdated Show resolved Hide resolved
compiler/ast/src/passes/visitor.rs Outdated Show resolved Hide resolved
errors/src/errors/static_analyzer/static_analyzer_error.rs Outdated Show resolved Hide resolved
compiler/passes/src/type_checking/checker.rs Outdated Show resolved Hide resolved
@mikebenfield
Copy link
Collaborator Author

Indeed, this issue is now fixed (and I've updated the last commit message to refer to it).

And I think this one is too. Maybe. The compiler will now give an error for the code in the example, because you can't assign a Future out of a tuple to a new variable like that. I think that suffices to fix this issue, but maybe there is still a problem around type checking futures?

@mikebenfield
Error for future parameters except on async functions.
a81b97d 
Also, fix the span for function inputs.
@mikebenfield
always add Future arguments to symbol table
9d52b65 
This way we don't get misleading error messages.
@mikebenfield
Fix future consumption checking.
7b88c3e 
Now futures are tracked properly, whether they're stored directly
in a variable or in a tuple.

Also, error if a future is used improperly.

Fixes #28471
d0cd
d0cd approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 402a8e4 into mainnet Dec 16, 2024
10 checks passed
@d0cd d0cd deleted the fix-futures branch December 16, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikebenfield @d0cd