Add PHPStan, fix some issues

.github/workflows/static.yml

@@ -0,0 +1,31 @@
+name: PHP static analysis
+
+on:
+  push:
+    branches: [ master, main ]
+  pull_request:
+    branches: [ master, main ]
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: ['8.2']
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          tools: composer:v2
+          coverage: none
+
+      - name: Install Dependencies
+        run: composer update --no-interaction --no-progress --ansi
+
+      - name: PhpStan
+        run: ./vendor/bin/phpstan analyse

.github/workflows/php.yml → .github/workflows/tests.yml

@@ -1,4 +1,4 @@
-name: PHP Unit/Quality CI
+name: PHP unit tests
 
 on:
   push:

composer.json

@@ -26,7 +26,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.0|^10.0",
-        "php-coveralls/php-coveralls": "^2.0"
+        "php-coveralls/php-coveralls": "^2.0",
+        "phpstan/phpstan": "^1.10"
     },
     "minimum-stability": "stable"
 }

phpstan.neon

@@ -0,0 +1,8 @@
+parameters:
+  level: 2
+  paths:
+    - src/
+    - tests/
+
+  ignoreErrors:
+    - '#Unsafe usage of new static.+#'

src/Builder/AttributeBuilder.php

@@ -196,7 +196,7 @@ public function addSubAttributes(array $attributes)
     }
 
     /**
-     * @param \string[] $canonicalValues
+     * @param string[] $canonicalValues
      *
      * @return AttributeBuilder
      */
@@ -208,7 +208,7 @@ public function setCanonicalValues(array $canonicalValues)
     }
 
     /**
-     * @param \string[] $referenceTypes
+     * @param string[] $referenceTypes
      *
      * @return AttributeBuilder
      */

src/Model/Resource.php

@@ -44,7 +44,7 @@ public function __construct($id)
     abstract public function getResourceType();
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getSchemas()
     {
@@ -123,7 +123,7 @@ public function serializeObject()
             if (!$extension) {
                 continue;
             }
-            if ($extension instanceof ResourceExtension) {
+            if ($extension instanceof SerializableInterface) {
                 $result[$schemaId] = $extension->serializeObject();
             } elseif (is_array($extension)) {
                 $result[$schemaId] = $extension;

src/Model/Schema/Attribute.php

@@ -59,12 +59,12 @@ class Attribute implements SerializableInterface
      * @param bool        $required
      * @param string      $description
      * @param Attribute[] $subAttributes
-     * @param \string[]   $canonicalValues
+     * @param string[]   $canonicalValues
      * @param bool        $caseExact
      * @param string      $mutability
      * @param string      $returned
      * @param string      $uniqueness
-     * @param \string[]   $referenceTypes
+     * @param string[]   $referenceTypes
      */
     public function __construct(
         $name,
@@ -143,7 +143,7 @@ public function getSubAttributes()
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getCanonicalValues()
     {
@@ -183,7 +183,7 @@ public function getUniqueness()
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getReferenceTypes()
     {
@@ -274,7 +274,7 @@ public static function deserializeObject(array $data)
                 $subAttributes[] = static::deserializeObject($subAttribute);
             }
         }
-        $result = new static(
+        return new static(
             $data['name'],
             $data['type'],
             $data['multiValued'],
@@ -288,7 +288,5 @@ public static function deserializeObject(array $data)
             isset($data['uniqueness']) ? $data['uniqueness'] : null,
             isset($data['referenceTypes']) ? $data['referenceTypes'] : []
         );
-
-        return $result;
     }
 }

src/Validator/ValidationResult.php

@@ -54,7 +54,7 @@ public function getErrors()
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getErrorsAsStrings()
     {