Allow passing a message size hint #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
force-pushed
the
message-size-hint
branch
2 times, most recently
from
704c5e2 to
d9f3052
Compare
Also, set the AEAD chunk size to twice the message size hint (or the actual message size, when known), so that we don't generate an overly large chunk size when the message could fit in a smaller chunk size.
twiss
force-pushed
the
message-size-hint
branch
from
d9f3052 to
07a6094
Compare
lubux
approved these changes
Dec 13, 2024
| @@ -3,13 +3,18 @@ package crypto | |||
| import "github.com/ProtonMail/go-crypto/openpgp/packet" | |||
|
|
|||
| type EncryptionProfile interface { | |||
| EncryptionConfig() *packet.Config | |||
| EncryptionConfig(messageSizeHint uint64) *packet.Config | |||
There was a problem hiding this comment.
We might need more options here in the future without breaking backward compatibility.
What about introducing a struct EncHandleSettings and passing &encHandleSettings instead with default nil?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, set the AEAD chunk size to twice the message size hint (or the actual message size, when known), so that we don't generate an overly large chunk size when the message could fit in a smaller chunk size.
This is useful to reduce the memory usage when en/decrypting AEAD message once ProtonMail/go-crypto#259 is merged.