Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update golang.org/x/exp dependency and fix breaking changes #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krostar
Copy link

@krostar krostar commented Jan 20, 2024

Hello!

Since this update of the golang/exp project, the slices package has a breaking change.

The commit message of the golang/exp package, introducing the regression, is explicit about it.

Note that this changes some of the sorting functions to use a
comparison function rather than a less function. We don't promise
backward compatibility in x/exp packages.

As far as I know, there is no urgency to update the golang/exp package version.

Step to reproduce the breaking change:

go get -u golang.org/x/exp
go test ./...
# github.com/ProtonMail/go-proton-api
./address.go:21:33: type func(a Address, b Address) bool of func(a, b Address) bool {…} does not match inferred type func(a Address, b Address) int for func(a E, b E) int
?   	github.com/ProtonMail/go-proton-api/server/cmd/client	[no test files]
?   	github.com/ProtonMail/go-proton-api/server/proto	[no test files]
FAIL	github.com/ProtonMail/go-proton-api [build failed]
FAIL	github.com/ProtonMail/go-proton-api/server [build failed]
FAIL	github.com/ProtonMail/go-proton-api/server/backend [build failed]
FAIL

Thank you for exposing and maintaining the proton api client.

@zoop-btc
Copy link

would be nice to get this fix in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants