Improve AEAD handling #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow explicitly indicating whether AEAD is supported when creating an SKESK packet, instead of looking at config.AEAD(). The config is no longer reliable, and we shouldn't mix SKESKv3 and SEIPDv2, for example.
…ricKeyEncryptedReuseKey These functions don't allow explicitly indicating whether AEAD is supported and are thus prone to misuse. The *AEAD versions should be used instead.
Document that the `aeadSupported` parameter passed to `SerializeEncryptedKeyAEAD[withHiddenOption]`, `SerializeSymmetricKeyEncryptedAEADReuseKey`, and `SerializeSymmetricallyEncrypted` must match.
lubux
reviewed
Nov 12, 2024
lubux
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializeSymmetricKeyEncryptedAEADReuseKeyAllow explicitly indicating whether AEAD is supported when creating an SKESK packet, instead of looking at
config.AEAD(), as the config is no longer reliable, and we shouldn't mix SKESKv3 and SEIPDv2, for example.SerializeEncryptedKey[WithHiddenOption]andSerializeSymmetricKeyEncryptedReuseKeyThese functions don't allow explicitly indicating whether AEAD is supported and are thus prone to misuse. The
*AEADversions should be used instead.Document that the
aeadSupportedparameter passed toSerializeEncryptedKeyAEAD[withHiddenOption],SerializeSymmetricKeyEncryptedAEADReuseKey, andSerializeSymmetricallyEncryptedmust match.