Cleartext Framework: Do not include the line ending separator in the decoded plaintext #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cleartext plaintext should not include the line ending separator given by the Cleartext Signed Message Structure.
|
TODO: Upstream change to GopenPGP.VerifyCleartext |
twiss
approved these changes
Nov 8, 2024
This was referenced Nov 8, 2024
lubux
added a commit
to ProtonMail/gopenpgp
that referenced
this pull request
Nov 11, 2024
Updates go-crypto to v1.1.2. See: ProtonMail/go-crypto#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleartext plaintext should exclude the line ending separator defined by the Cleartext Signed Message Structure. The line ending separator change was made to enhance interoperability, as the original implementation was non-deterministic—potentially adding a newline when the input lacked one.
GopenPGP removes the additional line ending separator, but this could be directly handled by go-crypto.