Remove auto zip preference in key generation

ProtonMail · Jun 21, 2024 · 610cabb · 610cabb
1 parent 20d9806
commit 610cabb
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/openpgp/key_generation.go b/openpgp/key_generation.go
@@ -122,10 +122,6 @@ func writeKeyProperties(selfSignature *packet.Signature, creationTime time.Time,
 	selfSignature.PreferredCompression = []uint8{uint8(packet.CompressionNone)}
 	if config.Compression() != packet.CompressionNone {
 		selfSignature.PreferredCompression = append(selfSignature.PreferredCompression, uint8(config.Compression()))
-		if config.Compression() == packet.CompressionZLIB {
-			// If zlib is supported also add zip
-			selfSignature.PreferredCompression = append(selfSignature.PreferredCompression, uint8(packet.CompressionZIP))
-		}
 	}
 
 	// And for DefaultMode.

diff --git a/openpgp/v2/key_generation.go b/openpgp/v2/key_generation.go
@@ -193,10 +193,6 @@ func writeKeyProperties(selfSignature *packet.Signature, selectedKeyProperties *
 	selfSignature.PreferredCompression = []uint8{uint8(packet.CompressionNone)}
 	if selectedKeyProperties.compression != packet.CompressionNone {
 		selfSignature.PreferredCompression = append(selfSignature.PreferredCompression, uint8(selectedKeyProperties.compression))
-		if selectedKeyProperties.compression == packet.CompressionZLIB {
-			// If zlib is supported also add zip
-			selfSignature.PreferredCompression = append(selfSignature.PreferredCompression, uint8(packet.CompressionZIP))
-		}
 	}
 
 	// And for DefaultMode.