Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce splash time to 1s. #768

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

Matafou
Copy link
Contributor

@Matafou Matafou commented May 5, 2024

The idea is that this splash screen annoys everyone, even in its new manga-style form.

I would even consider removing it completely but at least let us not have it last for 8 seconds by default.

The idea is that this splash screen annoys everyone, even in its new
manga-style form.

I would even consider removing it completely but at least let us not
have it last for 8 seconds by default.
@hendriktews
Copy link
Collaborator

I have (proof-splash-enable nil) since the second day I use PG. So yes, please merge.
(IMO it would be better to have it 3 or 4 seconds together with a bit button "Disable this splash screen for the future" at the front, but I don't feel inclined to spend time on it.)

@erikmd
Copy link
Member

erikmd commented May 12, 2024

AFAIAC, I only press q and it disappears immediately. Maybe this shortcut could just be made more visible?
or improving this splash screen so that yet another shortcut is put forth, to dismiss the screen once and for all?

@erikmd
Copy link
Member

erikmd commented May 12, 2024

YMMV anyway, and I don't object to merging this

@Matafou
Copy link
Contributor Author

Matafou commented May 13, 2024

At the time this splash screen was created (before I ever used pg) emacs used to freeze for a few seconds while PG was initializing and the user was tempted to hit C-g pavlovly. PG was then in a horrific half-initialized state. I think this is the motivation behind this initially.

Even with a non compiled PG this takes less than a second now, so I think we can remove it completely, except for folklore. Btw I think we don't have credit for this image. It was drawn by a chinese student duiring a coq school (second hand credit here: https://youzicha.tumblr.com/post/145836286669/in-the-lastest-version-of-proof-general-the-mascot).

@erikmd
Copy link
Member

erikmd commented Jun 15, 2024

@Matafou Ready to merge this now?

Even if Hendrik suggested a possible enhancement

(IMO it would be better to have it 3 or 4 seconds together with a bit button "Disable this splash screen for the future" at the front, but I don't feel inclined to spend time on it.)

it seems that the current version of this PR has the merit to be simple, and still greatly improve the situation

@Matafou
Copy link
Contributor Author

Matafou commented Jun 15, 2024

Sure. Sooner is better imho.

@Matafou Matafou merged commit b9fdbbf into ProofGeneral:master Jun 15, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants