Build pipeline fix, drop Drupal <10.1 support, flag PHP 8.2 support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr576
commented
Apr 8, 2024
| @@ -139,10 +139,16 @@ | |||
| }, | |||
| "scripts": { | |||
| "post-install-cmd": [ | |||
| "Pronovix\\SimpleSymlink\\ScriptHandler::createSymlinks" | |||
| "@symlink-for-local-dev-env" | |||
There was a problem hiding this comment.
As a replacement of pronovix/simple-symlink
mxr576
changed the title
|
Current builds are failing due to issues related to this old trick that happened in older versions of Drupal. https://github.com/Pronovix/swagger_ui_formatter/actions/runs/8597299839/job/23555697813 |
mxr576
force-pushed
the
april_fixes
branch
3 times, most recently
from
3efccf3 to
2f273fc
Compare
also fix QA pipeline
* Use `docker compose` instead of `docker-compose` * Remove PHP version lock suggestion from .env
mxr576
changed the title
This was referenced Apr 8, 2024
Closed
mxr576
commented
Apr 8, 2024
.dev/.ci/run-phpunit-tests.sh
Outdated
| @@ -5,5 +5,5 @@ set -e | |||
| if [[ ${RUN_PHPUNIT_TESTS} == true ]]; then | |||
| # Custom bootstrap file is required to prevent infinite loop caused by symlinking that Drupal's original | |||
| # bootstrap file cannot handle. | |||
| docker-compose run --rm php ./vendor/bin/phpunit -c web/core -v --debug --printer '\Drupal\Tests\Listeners\HtmlOutputPrinter' --bootstrap=vendor/pronovix/drupal-qa/src/Drupal/PhpUnit/bootstrap.php web/modules/drupal_module/tests/ | |||
| docker-compose run --rm php ./vendor/bin/phpunit -c web/core -v --debug --printer '\Drupal\Tests\Listeners\HtmlOutputPrinter' --bootstrap=/mnt/files/local_mount/tests/src/bootstrap.php web/modules/drupal_module/tests/ | |||
There was a problem hiding this comment.
This has to be an absolute path... ;S
dpagini
reviewed
Apr 8, 2024
lekob
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix QA pipeline
Closes #93.