-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish the NumPy content #240
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 7a30ddb |
Hi @dopplershift and @anissa111, would you be able to take a look at this PR sometime soon, or should I reassign to different reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks for making all those capitalization changes and updating the NumPy landing page @brian-rose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe with the changes I pushed up (just typo fixes and some grammar), this looks good to me.
This PR partially addresses #231 by removing "Under construction" from the NumPy landing page. Also adds the Numpy logo to that page, and fixes some small styling issues throughout the NumPy notebooks (e.g. consistent capitalization of the words "NumPy", "Maplotlib", "Xarray", etc.