-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert MiradorImageTools to functional component to fix no image bug #52
base: mirador4-compat-clean
Are you sure you want to change the base?
fix: convert MiradorImageTools to functional component to fix no image bug #52
Conversation
@lutzhelm sure :) i just updated to alpha 4 |
Currently the tests are failing; you will also need to remove the
|
oh...:/ now the tests are working again |
updateViewport, | ||
updateWindow, | ||
t, | ||
innerRef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, there is just one last thing: could you order the props alphabetically?
innerRef: PropTypes.oneOfType([ | ||
PropTypes.func, | ||
PropTypes.any, | ||
]).isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... same here: could you move innerRef
up to have an alphabetical order?
I converted the MiradorImageTools class component to a functional one, due the usage of hooks inside the mirador
withSize
HOC.For usage i had to install a prepublish build as described by lutzhelm here.