Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable by-tag view on mobile platform #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

snylonue
Copy link
Contributor

No description provided.

@Yesterday17
Copy link
Member

Yesterday17 commented Jul 27, 2024

I removed this page on mobile for the following reasons:

  1. Retrieving albums by tag is essentially a search function.
  2. Since this is a search feature, it should be included on the search page. Therefore, ‘search’ is now in the bottom navigation bar.

However, due to the lack of ui design, the by-tag view was left removed and no replacement was introduced. If you have free time, maybe we can discuss further about working on the search view?

@snylonue
Copy link
Contributor Author

The pr is meant for a temporary solution since I make heavy use of the feature.

Since this is a search feature, it should be included on the search page.

If so, we may take #41 into consideration as well. Maybe we can integrate them into the search view.
It also reminds me of the search bar's absence on desktop.

If you have free time, maybe we can discuss further about working on the search view?

Shall we discuss it on github or telegram group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants