Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pdf generation sample using pdfMake, and jsPDF JavaScript libraries #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kumarandena
Copy link
Contributor

@cla-bot
Copy link

cla-bot bot commented Mar 1, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kumaran.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@rdlauer
Copy link
Contributor

rdlauer commented Mar 2, 2019

@kumarandena Can you fill out the CLA form? You should have received details in an email. Thanks!

@rdlauer
Copy link
Contributor

rdlauer commented Mar 2, 2019

This sample is cool - but I wonder if it's possible to load the PDF in a browser or a WebView automatically?

@cla-bot
Copy link

cla-bot bot commented Mar 4, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kumaran.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@kumarandena
Copy link
Contributor Author

kumarandena commented Mar 4, 2019

@rdlauer I tried the same but no luck! If I tried with the default browser, openUrl API from utilsModule will accept only the URL with a proper protocol or the pdf from a webserver.
Of course, the Webview module also requires the same input. Don't find a way to load the base64 content of the pdf automatically.
If we will get any way to do this in the future then we can add that along with other frameworks support of this same sample! What do you think?

@kumarandena
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 4, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kumaran.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Mar 4, 2019

The cla-bot has been summoned, and re-checked this pull request!

@kumarandena
Copy link
Contributor Author

@rdlauer Can you please help me on this? I have already signed the CLA and also checked the local and global git config details. Both user name and email are correct only. Still, CLA status verification keeps failing...

Kumarans-MacBook-Pro:code-samples kumaran$ git config --list | grep email [email protected]

Kumarans-MacBook-Pro:code-samples kumaran$ git config user.name
kumarandena

@rdlauer
Copy link
Contributor

rdlauer commented Mar 4, 2019

@etabakov Can you check on why this isn't working for @kumarandena? (see above)

@rdlauer
Copy link
Contributor

rdlauer commented Mar 4, 2019

Regarding the sample itself - yeah I think unless you can show a PDF in the app, there isn't as much value in copying and pasting. We can wait until a better solution appears :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants