Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Buy Our eBooks" Button in Dark Mode #852

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sourabhmajoka
Copy link
Contributor

Title of the Pull Request

  • Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #849
image

Description

The "Buy Our eBooks" button was not visible in dark mode due to styling issues. This PR updates the CSS to make the button clearly visible in both light and dark modes by applying appropriate background and text colors, ensuring accessibility for all users.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the code style of this project.
  • I have followed the contribution guidelines
  • I have performed a self-review of my own code.
  • I have ensured my changes don't generate any new warnings or errors.
  • I have updated the documentation (if necessary).
  • I have resolved all merge conflicts.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skillwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 11:57am

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for skillwise ready!

Name Link
🔨 Latest commit 97e70ca
🔍 Latest deploy log https://app.netlify.com/sites/skillwise/deploys/671cd936186e61000817fe58
😎 Deploy Preview https://deploy-preview-852--skillwise.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit 5157823 into PriyaGhosal:main Oct 30, 2024
5 checks passed
@PriyaGhosal
Copy link
Owner

@sourabhmajoka
Great contribution ! 🎉
Your pull request has been successfully merged! Also Take a moment to ⭐ Star the repository if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "Buy Our eBooks" Button in Dark Mode
2 participants