Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 1.21.3 Support #936

Merged
merged 67 commits into from
Dec 3, 2024
Merged

Java 1.21.3 Support #936

merged 67 commits into from
Dec 3, 2024

Conversation

GroobleDierne
Copy link
Contributor

@GroobleDierne GroobleDierne commented Oct 27, 2024

Fixes #929, #928

TODO:

  • Protocol
    • packet_recipe_book_add
    • packet_craft_recipe_response should be similar to previous one
    • Fix Slot & SlotComponent types
    • packet_declare_recipes
  • entities.json (waiting on minecraft-data-generator)
  • tints.json is likely incorrect

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

Can you point missing files to 1.21.1 for now

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

Let's open an nmp and mineflayer PRs using this

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

nmp and mineflayer PRs

PrismarineJS/node-minecraft-protocol#1347
PrismarineJS/mineflayer#3489

fail due to wrong protocol as expected

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

see https://github.com/extremeheat/extracted_minecraft_data/pulls as a source of info for the protocol

@rom1504
Copy link
Member

rom1504 commented Oct 27, 2024

@GroobleDierne
Copy link
Contributor Author

see https://github.com/extremeheat/extracted_minecraft_data/pulls as a source of info for the protocol

I'm using yarn because some files failed to decompile in extremheat's repository.
Anyway, I'll stop here for tonight.

@rom1504
Copy link
Member

rom1504 commented Oct 31, 2024

@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

Hey, please remove registries.json file from this PR and put it in its own PR. I think we need a lot more work on it to include in mc data

@rom1504
Copy link
Member

rom1504 commented Nov 27, 2024

Also let's review GroobleDierne#2

@GroobleDierne
Copy link
Contributor Author

Hey, please remove registries.json file from this PR and put it in its own PR. I think we need a lot more work on it to include in mc data

I realised that if the client and server share the same minecraft:core pack version (communicated through SelectKnowPacks), the server only needs to send every key from every registries. So my current plan is to implement this in p-registry, as for most registries, mc-data already has the data to generate the keys. In the long term, we must add some fields to the existing schemas and create new ones too.

@GroobleDierne
Copy link
Contributor Author

After a looooooot of debugging, I figured out the bug was just in front of my eyes in the registryHolderSet decoding code and not in the protocol definition 🥹

@GroobleDierne GroobleDierne marked this pull request as ready for review November 27, 2024 22:07
@Cleboost
Copy link

Cleboost commented Dec 1, 2024

When do you think it will be released?

@TheJupiterDev
Copy link

What all needs done before this is done ?

@rom1504
Copy link
Member

rom1504 commented Dec 3, 2024

Lgtm I think all comments from extremeheat were fixed as well

Let's merge and iterate on further PRs

@rom1504 rom1504 merged commit 2442f47 into PrismarineJS:master Dec 3, 2024
4 checks passed
@rom1504
Copy link
Member

rom1504 commented Dec 3, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Support Minecraft PC 1.21.3
6 participants