-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 1.21.3 Support #936
Java 1.21.3 Support #936
Conversation
Can you point missing files to 1.21.1 for now |
Let's open an nmp and mineflayer PRs using this |
nmp and mineflayer PRs PrismarineJS/node-minecraft-protocol#1347 fail due to wrong protocol as expected |
see https://github.com/extremeheat/extracted_minecraft_data/pulls as a source of info for the protocol |
…packet_settings, add packet_select_bundle_item add packet_tick_end
I'm using yarn because some files failed to decompile in extremheat's repository. |
…play phase, add some TODOs
https://github.com/PrismarineJS/node-minecraft-protocol/actions/runs/11543601911/job/32356083688 now passing but still some packet errors |
Hey, please remove registries.json file from this PR and put it in its own PR. I think we need a lot more work on it to include in mc data |
Also let's review GroobleDierne#2 |
This reverts commit ab03598.
I realised that if the client and server share the same minecraft:core pack version (communicated through SelectKnowPacks), the server only needs to send every key from every registries. So my current plan is to implement this in p-registry, as for most registries, mc-data already has the data to generate the keys. In the long term, we must add some fields to the existing schemas and create new ones too. |
After a looooooot of debugging, I figured out the bug was just in front of my eyes in the registryHolderSet decoding code and not in the protocol definition 🥹 |
When do you think it will be released? |
What all needs done before this is done ? |
Lgtm I think all comments from extremeheat were fixed as well Let's merge and iterate on further PRs |
/makerelease |
Fixes #929, #928
TODO: