Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 메시지함 Paging 속성 계산 오류 #115

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[Fix] 메시지함 Paging 속성 계산 오류 #115

merged 1 commit into from
Oct 17, 2024

Conversation

loveysuby
Copy link
Contributor

🚀 Related Issue

close: #114

📌 Tasks

  • 수신 메시지함 조회 시 cursor paging response 관련 속성 바인딩 오류 수정
    • 기존 : SELECT limit+1 FROM ENTITY로 수행된 결과를 그대로 사용
    • 수정 : Query단 LIMIT <-> request LIMIT 비교 수행 후 바인딩
  • cursorPageInfo 관련 직렬화 테스트 추가

📝 Details

📚 Remarks

Points or opinions to share teams

@loveysuby loveysuby linked an issue Oct 17, 2024 that may be closed by this pull request
[Fix] 메시지함 Paging 속성 계산 오류 #114
Closed
@loveysuby loveysuby self-assigned this Oct 17, 2024
@loveysuby loveysuby added 🐛 bug Fix a bug ✅ test Test for add, update, check labels Oct 17, 2024
@loveysuby loveysuby merged commit 1dcc98e into develop Oct 17, 2024
1 check passed
@loveysuby loveysuby deleted the fix/114 branch October 17, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@loveysuby loveysuby

Labels
🐛 bug Fix a bug ✅ test Test for add, update, check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 메시지함 Paging 속성 계산 오류
1 participant
@loveysuby