[PS 8] Tools::jsonDecode change to json_decode #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see, noone cares :-D Great... |
|
Why I waste my time for fixing something for free, if nobody is will not appreciate? |
|
Hi @ShaiMagal, I understand your frustration, but this module looks like "abandoned". |
|
@ShaiMagal If you look at this repository history, you'll see it was mostly maintained by Scritik. Apart from a PR merged in 2022, the repository received no activity since 2017. So I guess @marsaldev is right: this repository has no clear owner today. |
|
LGTM 👍🏼 |
|
@matks So, module should be sent to Recycle Bin and totally deleted. (or archived at least - not repository looks "live")... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools::jsonDecode and Tools::jsonEncode is removed in PS 8.x
Related issues:
#19
PrestaShop/PrestaShop#34583