Skip to content

Commit

Permalink
Improve jobs naming
Browse files Browse the repository at this point in the history
  • Loading branch information
jolelievre committed Sep 14, 2023
1 parent b1e4f5a commit 75b399a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/pr_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ on:
jobs:
# Sanity tests are run independently because it's the only campaign that handles the installation itself, since it tests it
sanity-test:
name: Sanity campaign
uses: ./.github/workflows/test-sanity.yml
with:
pr_number: ${{ inputs.pr_number }}
Expand All @@ -76,6 +77,7 @@ jobs:

# We perform a unique build that is stored as an artifact, only then do we start the campaign that will rely on this build
build-shop:
name: Prebuild shop and export artifacts
uses: ./.github/workflows/build-shop.yml
with:
pr_number: ${{ inputs.pr_number }}
Expand All @@ -90,6 +92,7 @@ jobs:
# be too long or too many runners will be blocked by these campaigns and the split would be counter-productive, it's a
# delicate balance to maintain The criteria so far was campaign longer than 15min
test-long-campaigns:
name: Run long campaign ${{ matrix.TEST_COMMAND }}
needs: build-shop
uses: ./.github/workflows/test-with-prebuilt-shop.yml
with:
Expand Down Expand Up @@ -125,6 +128,7 @@ jobs:
TEST_COMMAND: 'functional:FO:classic:08-12'

test-short-campaigns:
name: Run short campaign ${{ matrix.TEST_COMMAND }}
needs: build-shop
uses: ./.github/workflows/test-with-prebuilt-shop.yml
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pr_test_single_campaign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ on:

jobs:
build-shop:
name: Prebuild shop and export artifacts
uses: ./.github/workflows/build-shop.yml
with:
pr_number: ${{ inputs.pr_number }}
Expand All @@ -121,6 +122,7 @@ jobs:
backoffice_layout: ${{ inputs.backoffice_layout }}

test-pr:
name: Run single campaign ${{ inputs.test_command }}
needs: build-shop
uses: ./.github/workflows/test-with-prebuilt-shop.yml
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-sanity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
echo Build docker via docker composer
USER_ID=$(id -u) GROUP_ID=$(id -g) docker-compose -f docker-compose.yml up -d --build prestashop-git
- name: Start sanity campaign
- name: Run sanity campaign
uses: ./custom_actions/.github/workflows/actions/run-tests
with:
base_branch: ${{ inputs.base_branch }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-with-prebuilt-shop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
echo Waiting for response from the FO
bash -c 'while [[ "$(curl -L -s -o /dev/null -w %{http_code} ${{ env.URL_FO }}en/)" != "200" ]]; do sleep 5; done'
- name: Start UI tests on prebuilt shop
- name: Run campaign ${{ inputs.test_command }} on prebuilt shop
uses: ./custom_actions/.github/workflows/actions/run-tests
with:
base_branch: ${{ inputs.base_branch }}
Expand Down

0 comments on commit 75b399a

Please sign in to comment.