Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new password policy introduced in 8.0 #1593

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

thomasnares
Copy link
Contributor

Questions Answers
Branch? 1.7.x / 8.x
Description? Documentation about the new password policy with zxcvbn introduced in 8.0
Related PR? PrestaShop/classic-theme#21 , PrestaShop/PrestaShop#28127 , #1436

@github-actions github-actions bot added the 8.x label Jan 9, 2023
@thomasnares
Copy link
Contributor Author

@NeOMakinG you may have suggestions for me about what to document on the frontend part ?
@PierreRambaud you may also have suggestions for me about backend part 👍

menuTitle: New password policy
---

# New password policy introduced in 8.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it would be more interesting to document this from a system reference standpoint rather from a "how to update your software"? I think it could be overly specific otherwise.

Or perhaps the doc can be split in two: one which explains how the password policy is integrated with customers and employees (for reference), and another one that describes how to update existing code (useful for upgrade only).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look better with the new commit ?

@NeOMakinG
Copy link

@NeOMakinG you may have suggestions for me about what to document on the frontend part ? @PierreRambaud you may also have suggestions for me about backend part 👍

I guess that's fine enough, we may talk about the fact that Zxcbn is loaded async on core.js side because his size is huge but that's it, nothing else to explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants