Merge pull request #1 from jolelievre/php84-compatibility

Php 8.4 compatibility
PrestaShop · Nov 29, 2024 · 7a44c4f · 7a44c4f
2 parents dec667f + 471591c
commit 7a44c4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,6 +1,6 @@
 name: CI
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
   build-test:
@@ -16,6 +16,7 @@ jobs:
           - 7.4
           - 8.2
           - 8.3
+          - 8.4
           - nightly
 
     steps:
@@ -38,4 +39,4 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: code-coverage-report
-          path: coverage/html
+          path: coverage/html
diff --git a/src/PHPSQLParser/processors/AbstractProcessor.php b/src/PHPSQLParser/processors/AbstractProcessor.php
@@ -62,9 +62,9 @@ abstract class AbstractProcessor {
     /**
      * AbstractProcessor constructor.
      *
-     * @param Options $options
+     * @param Options|null $options
      */
-    public function __construct(Options $options = null)
+    public function __construct(?Options $options = null)
     {
         $this->options = $options;
     }