Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cached property #105

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Remove cached property #105

merged 2 commits into from
Jan 9, 2025

Conversation

mevangelista-alvarado
Copy link
Contributor

No existen funciones en segundo plano, es decir que method.delay()

Lo que se noto es que si existen métodos con la propiedad @cached_property, esto calcula un valor y lo guarda en cache.

Se quito dicha propiedad a los métodos que calculan el campo hash_before.

Esto hará que el calculo sea lento pero si obtenga el valor actualizado y no un valore previamente calculado.

Copy link
Contributor

@ebarojas ebarojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Se ve muy bien.

@@ -114,7 +114,6 @@ def create_raw_msg(self):
)
self.raw_msg = msg.encode('utf-8')

@cached_property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mevangelista-alvarado
Copy link
Contributor Author

Se crearon 6 bloques nuevos y todo funciono bien en https://rexchain-staging.herokuapp.com/

La Rx que se uso en de hace 4 años aprox como lo indica el buscador de RexChain

image

@mevangelista-alvarado
Copy link
Contributor Author

mevangelista-alvarado commented Dec 23, 2024

@ebarojas
Cuando se suba, hay que estar al pendiente monitoreando los bloques

@ebarojas ebarojas merged commit 0a0646f into develop Jan 9, 2025
@ebarojas ebarojas deleted the feature/remove_cached_property branch January 9, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants