Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package all manifests with release #87

Merged
merged 15 commits into from
Sep 20, 2024

Conversation

jamiezieziula
Copy link
Contributor

@jamiezieziula jamiezieziula commented Sep 20, 2024

This PR adds logic to template the helm charts into plain kubernetes manifests. We utilize yq to remove references to helm & update the version referenced across all manifests to match the app version being released.

Also updates helm-unittest and operator-lint-and-test workflows to only run on PRs against main & when the relevant directory has changes

Closes PLA-334

@jamiezieziula jamiezieziula added the docs Documentation-related changes label Sep 20, 2024
@jamiezieziula jamiezieziula added maintenance Maintenance-related changes and removed docs Documentation-related changes labels Sep 20, 2024
Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the concept but I'll defer to Mitch for the nuts & bolts

.github/workflows/release.yaml Show resolved Hide resolved
@jamiezieziula jamiezieziula merged commit f3eefc7 into main Sep 20, 2024
4 checks passed
@jamiezieziula jamiezieziula deleted the package-all-manifests-with-release branch September 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants