-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package all manifests with release #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiezieziula
commented
Sep 20, 2024
jamiezieziula
added
maintenance
Maintenance-related changes
and removed
docs
Documentation-related changes
labels
Sep 20, 2024
jamiezieziula
commented
Sep 20, 2024
mitchnielsen
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
chrisguidry
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of the concept but I'll defer to Mitch for the nuts & bolts
mitchnielsen
approved these changes
Sep 20, 2024
Co-authored-by: Mitchell Nielsen <[email protected]>
…om/PrefectHQ/prefect-operator into package-all-manifests-with-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to template the helm charts into plain kubernetes manifests. We utilize
yq
to remove references tohelm
& update the version referenced across all manifests to match the app version being released.Also updates
helm-unittest
andoperator-lint-and-test
workflows to only run on PRs against main & when the relevant directory has changesCloses PLA-334