Remove kube-rbac-proxy and related configuration #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes configuration related to kube-rbac-proxy, which is deprecated. Related to PLA-318
- Removes secureMetrics setting from main.go - Removes servicemonitor resource and related Helm settings These were incomplete and untested, and we'll eventually come back to this with a more modern and tested implementation.
mitchnielsen
changed the title
chrisguidry
approved these changes
Oct 24, 2024
jamiezieziula
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes existing
kube-rbac-proxy-related configuration because this component is deprecated and no longer available. We'll follow up with a more up-to-date and validated implementation of metrics endpoint protection in future PRs.Closes https://linear.app/prefect/issue/PLA-446/remove-existing-metrics-protection-from-prefect-operator