Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update & cleanup workflows. Also introduce make to manage dependencies and testing #392

Merged
merged 9 commits into from
Oct 2, 2024
Merged

chore: Update & cleanup workflows. Also introduce make to manage dependencies and testing #392

merged 9 commits into from
Oct 2, 2024

Conversation

jamiezieziula
Copy link
Contributor

@jamiezieziula jamiezieziula commented Oct 2, 2024 •
edited
Loading

This PR does the following:

  • adds --- from the top of all yaml files
  • restricts GHA permissions
  • uses GH_TOKEN and GITHUB_TOKEN where appropriate
  • adds the Notify on Failure workflow to push slack alerts when certain workflows fail
  • updates mise & pre-commit dependencies
  • adds yamllint
  • adds a Makefile with commands to ease local development
  • updates readme to reflect the make changes

Relates to PLA-369

@jamiezieziula jamiezieziula marked this pull request as ready for review October 2, 2024 19:20
@jamiezieziula jamiezieziula requested a review from a team as a code owner October 2, 2024 19:20
mitchnielsen
mitchnielsen reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@mitchnielsen mitchnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@jamiezieziula jamiezieziula merged commit 16957fc into main Oct 2, 2024
13 checks passed
@jamiezieziula jamiezieziula deleted the failure-alert-workflow branch October 2, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchnielsen mitchnielsen mitchnielsen approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiezieziula @mitchnielsen