Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests #390

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Add more unit tests #390

merged 8 commits into from
Sep 30, 2024

Conversation

mitchnielsen
Copy link
Contributor

@mitchnielsen mitchnielsen commented Sep 27, 2024

Summary

Adds more unit tests to the charts.

Related to https://linear.app/prefect/issue/PLA-138/create-helm-tests-for-workerserver-charts

Note: given the amount of pre-existing code here, I generated these with Cursor (via Claude). I then tweaked the tests to make sure they used the right configuration and expected the correct output. This won't be 100% code coverage, but gives us a baseline. When we make changes in the future, we can either modify or add tests now that we have things set up.

Testing

  • Check the unittest job - example
  • Run the tests locally: ./scripts/helm_unittest.sh

@mitchnielsen mitchnielsen self-assigned this Sep 27, 2024
@mitchnielsen mitchnielsen marked this pull request as ready for review September 27, 2024 19:07
@mitchnielsen mitchnielsen requested a review from a team as a code owner September 27, 2024 19:07
@mitchnielsen mitchnielsen merged commit 16d85c9 into main Sep 30, 2024
13 checks passed
@mitchnielsen mitchnielsen deleted the add-more-unit-tests branch September 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants