Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix error in deployment steps #121

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Oct 10, 2023

Switches to the sync version of DefaultAzureCredential to resolve errors when using default credentials with the deployment steps in this library.

Closes PrefectHQ/prefect#10764
Closes #115

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle requested a review from a team as a code owner October 10, 2023 14:46
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@desertaxle desertaxle merged commit bd8aa49 into main Oct 10, 2023
5 checks passed
@zzstoatzz zzstoatzz deleted the fix-default-credentials-in-deployment-steps branch October 10, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants