New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PENGSOL-248 fix open transactions when initializing dwh connection #11

Merged

DawidMakar-acaisoft merged 3 commits into main from PENGSOL-248-fix-open-transactions-when-initializing-dwh-connection

Oct 30, 2024

Collaborator

DawidMakar-acaisoft commented Oct 30, 2024

The PR consists of:

close opened transactions when using fetch/execute methods (followed by Jørn's report: https://tgs.atlassian.net/browse/PENGSOL-248)
fixed using Dwh as context manager
update test cases (ensure that transactions are closed)
lock dependencies' versions
separate test dependencies from library dependencies
add a note in the readme file on how the test dependencies should be installed

Dawid Makar added 3 commits

October 30, 2024 09:26


          PENGSOL-248: prevent from keeping open Data Warehouse transactions

bbfa663


          PENGSOL-248: lock dependencies' versions

f41f06f


          Update the readme file with testing instructions

d049a17

DawidMakar-acaisoft requested a review from pavel-tashev

October 30, 2024 10:15

pavel-tashev approved these changes

View reviewed changes

Collaborator

pavel-tashev left a comment

Great work!

DawidMakar-acaisoft merged commit b2255ec into main

8 checks passed

DawidMakar-acaisoft deleted the PENGSOL-248-fix-open-transactions-when-initializing-dwh-connection branch

October 30, 2024 11:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet