feat(Leboncoin): fix and improve pratically everything #9227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed "Mes annonces sauvegardées" to "Mes annonces" for better clarity. - The previous term implied "Saved items", but it actually represents "My items" that the user is selling. Signed-off-by: Lenoch <[email protected]>
- Introduced a new presence for the "Favorites" page on LeBonCoin (`leboncoin.fr/favorites`). - Displays activity for saved or favorited items. Signed-off-by: Lenoch <[email protected]>
- Added `getAdvertiserName()` and `getAdPrice()` functions to improve detection. - Added "/profile" alias to "/profil". - Fixed CSS queries for profiles and search results (`/profil/`-`/profile/` & `/recherche`). - Removed `/voitures` and `/commerces_marches/` as they are now duplicates of `/ad/`. - Improved consistency in extracting ad details and handling missing data. - Added myself (`LenochJade`) to the contributors list in `metadata.json`.
- Adjusted price formatting for `/offres_d_emploi/` pages to correctly display salaries instead of sale prices. - Now prefixes job salaries with "Payé" instead of "Vendu". - Ensured presence data updates correctly even if some price details are missing.
- Added detection for `/boutique` pages to display shop names in the presence.
- Uses `document.querySelector("h1.mb-md")?.textContent` to extract the boutique name.
- Includes a button linking to the boutique page.
- Added detection for the homepage (`/`) with the state "Page d'accueil". - Set a generic "Explore" presence for other unknown pages.
theusaf
requested changes
Jan 29, 2025
theusaf
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several improvements and fixes related to the LeBonCoin presence integration. The changes include new presence support for various LeBonCoin pages (almost all of them ig), refinements to the detection of prices and advertisers, and fixes for translation issues. Additionally, minor refactors and cleanup were performed.
Changes:
Added support
/) with the state "Page d'accueil"./boutique)./favorites).Fixed presences
/profilealias to deprecated/profil./profil/&/profile/)./recherche)./account).Improvements
getAdvertiserName()andgetAdPrice()functions to improve detection./offres_d_emploi/(job offers) pages to correctly display salaries instead of sale prices. ("Payé 12€ brut/heure" instead of "Vendu 12€")/voituresand/commerces_marches/as they are now duplicates of/ad/.Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected