fix group by alias translation in duck db

PrateekGarg-gs · Oct 1, 2024 · e5239d2 · e5239d2
1 parent d6798e2
commit e5239d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...rc/main/resources/core_relational_duckdb/relational/sqlQueryToString/duckdbExtension.pure b/...rc/main/resources/core_relational_duckdb/relational/sqlQueryToString/duckdbExtension.pure
@@ -273,7 +273,7 @@ function <<access.private>> meta::relational::functions::sqlQueryToString::duckD
                                 )
   ) +
   if (eq($opStr, ''), |'', | ' ' + $format.separator + 'where ' + $opStr) +
-  if ($s.groupBy->isEmpty(),|'',| ' ' + $format.separator + 'group by '+$s.groupBy->processGroupByColumns($dbConfig, $format->indent(), true, $extensions)->makeString(',')) +
+  if ($s.groupBy->isEmpty(),|'',| ' ' + $format.separator + 'group by '+$s.groupBy->processGroupByColumns($dbConfig, $format->indent(), false, $extensions)->makeString(',')) +
   if (eq($havingStr, ''), |'', | ' ' + $format.separator + 'having ' + $havingStr) +
   if ($s.orderBy->isEmpty(),|'',| ' ' + $format.separator + 'order by '+ $s.orderBy->processOrderBy($dbConfig, $format->indent(), $config, $extensions)->makeString(',')) +
   processLimit($s, $dbConfig, $format, $extensions, processTakeDefault_SelectSQLQuery_1__Format_1__DbConfig_1__Extension_MANY__String_1_, processSliceOrDropForDuckDB_SelectSQLQuery_1__Format_1__DbConfig_1__Extension_MANY__Any_1__String_1_);

diff --git a/...ure/src/main/resources/core_relational/relational/sqlQueryToString/testSuite/testDDL.pure b/...ure/src/main/resources/core_relational/relational/sqlQueryToString/testSuite/testDDL.pure
@@ -27,13 +27,14 @@ function <<paramTest.Test>> meta::relational::tests::dbSpecificTests::sqlQueryTe
 
    meta::relational::dbTestRunner::doSetupOnConnection($records, meta::relational::tests::dbSpecificTests::sqlQueryTests::ddl::db,
                                                      $config, meta::relational::extension::relationalExtensions());
+  // if there is any error in creating table or inserting data > the test fails
   true;
 }
 
 
 function <<paramTest.Test>> meta::relational::tests::dbSpecificTests::sqlQueryTests::ddl::testCreateTableForAllColumnDataTypes(config:DbTestConfig[1]):Boolean[1]
 {
-  //insert empty data > ensure create table statement is properly transl;ated for all column data types
+  //insert empty data > ensure create table statement is properly translated for all column data types
    meta::relational::dbTestRunner::doSetupOnConnection('', meta::relational::tests::dbSpecificTests::sqlQueryTests::ddl::dataTypeDB,
                                                      $config, meta::relational::extension::relationalExtensions());
   true;