Fix common parameters for PowerShell 7.4.0. #611
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
kilasuit
approved these changes
Dec 2, 2023
MartinGC94
reviewed
Dec 28, 2023
| @@ -2542,7 +2542,8 @@ function ConvertPsObjectsToMamlModel | |||
| 'InformationVariable', | |||
| 'OutVariable', | |||
| 'OutBuffer', | |||
| 'PipelineVariable' | |||
| 'PipelineVariable', | |||
| 'ProgressAction' | |||
There was a problem hiding this comment.
This whole section could be replaced with: [System.Management.Automation.PSCmdlet]::CommonParameters that way we can avoid this problem in the future.
In the other sections where it's written out in a string you could do something like: [System.Management.Automation.PSCmdlet]::CommonParameters | foreach -Begin {$Res = ""} -Process {$Res+= "-$_, "} -End {$Res.Trim(', ')}
There was a problem hiding this comment.
Agree that this is the best way to solve for all.
|
@sdwheeler Could we get a minor release with this soon? Moving to CommonParameters sounds like a v2 improvement 🙂 Just need to fix our broken docs for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds handling and test coverage for the new
-ProgressActioncommon parameter introduced with PowerShell 7.4.0.PR Context
Fixes issue #595 see this issue for further detail.