-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem #2136
base: main
Are you sure you want to change the base?
Conversation
59af6f2
to
42c028f
Compare
@andyleejordan Curious your thoughts on this. It ended up being heavier-handed than I wanted with all the async changes, but I'm wondering if that would be desirable if I split it into a separate MR? I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not. |
42c028f
to
e72a219
Compare
974e92e
to
1faf9f2
Compare
Can you talk through what you're trying to solve? When you make a synchronous method return |
1faf9f2
to
974e92e
Compare
caa9e27
to
677f42c
Compare
80b2351
to
9ce8911
Compare
PR Summary
Removes artificial Uri schema restriction, provides a mechanism for language clients to specify URIs that direct to PSProviders
PR Context