Update unix local user paths #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Starting in .NET 8, the behavior of Environment.GetFolderPath on Unix operating systems will change.
.NET 8 and above include breaking changes that impact paths which PSResourceGet relies on for script and module installation and discovery. When using
CurrentUserscope, PSResourceGet uses the .NET environment variableEnvironment.SpecialFolder.LocalApplicationDatato retrieve the appropriate path.See GetFolderPath behavior on Unix for an exact mapping on both Linux and macOS systems.
What this means is that PSResourceGet, which is expected to use
$HOME/.local/share/powershell/Modules, actually uses$HOME/Library/Application Support/powershell/Modulesif .NET 8+ is in use.
This can cause unexpected issues for a couple of reasons any modules or scripts installed with .NET 7 and below will not be discoverable with .NET 8 and above.
This PR resolves the issue by retrieving the unix local user path in a similar manner as PowerShell, by hardcoding the path.
PR Context
Resolves #1454
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.