Add method to extract nupkg to directory #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
requested review from
anamnavi and
adityapatwardhan
and removed request for
anamnavi
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adityapatwardhan
requested changes
Oct 23, 2023
adityapatwardhan
approved these changes
Oct 25, 2023
|
Slight correction to the description: GitHub Packages repository does not modify the nupkg files on it's own, but a certain popular tool does (wich results in a duplicated If you publish a valid nupkg to GitHub Packages directly, e.g. using |
anamnavi
pushed a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some repositories (namely GitHub Packages) add an extra
_rels\relsfile to the .nupkgs.System.IO.Compression.ZipFile.ExtractToDirectorydoes not have anoverwriteparameter for net472, so this method was throwing an exception every time it came across the second_rels\rels.This PR opens the .nupkg and runs
ExtractToFile(which does have anoverwriteparameter) on each item so that no exception gets thrown. Note that anything under_relsby default gets thrown out by PSResourceGet, so overwriting this file is not an issue. There should be no other duplicate files.PR Context
Resolves #1433
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.