Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more intuitive error message when JFrog feed is inactive #1427

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Provide more intuitive error message when JFrog feed is inactive #1427

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65d25b4
provide more intuitive error message when JFrog feed is inactive
anamnavi Sep 29, 2023
e165ad9
update RequiredResource test to have an empty inner hashtable scenario
anamnavi Sep 29, 2023
d29b038
Revert "update RequiredResource test to have an empty inner hashtable…
anamnavi Oct 3, 2023
ec6fe9a
catch specific exception
anamnavi Oct 4, 2023
8554746
catch specific exception
anamnavi Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/code/V3ServerAPICalls.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,11 +1474,23 @@ private JsonElement[] GetJsonElementArr(string request, string propertyName, out
}
catch (Exception e)
{
errRecord = new ErrorRecord(
exception: e,
"GetResponsesFromRegistrationsResourceFailure",
if (e.Message.Contains("'<' is an invalid start of a value"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway we can check the response so that if it can catch malformed responses more generically? Like using JsonDocument.TryParse() and throwing recording an error if that fails?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we check what the type of the exception is. That might be helpful too.

{
// scenario where the feed is not active anymore, i.e confirmed for JFrogArtifactory. The default error message is not intuitive.
errRecord = new ErrorRecord(
exception: new Exception($"JSON response from repository {Repository.Name} could not be parsed due to the feed being inactive or invalid, with inner exception: {e.Message}"),
"FindVersionGlobbingFailure",
ErrorCategory.InvalidResult,
this);
}
else
{
errRecord = new ErrorRecord(
exception: e,
"GetResponsesFromRegistrationsResourceFailure",
ErrorCategory.InvalidResult,
this);
}
}

return entries;
Expand Down