Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

replace PSDesResources with PSDscResources in URLs #125

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jsmartbnl
Copy link

@jsmartbnl jsmartbnl commented Dec 31, 2018

Fixed a typo where /PSDesResources/ was used instead of /PSDscResources/ in some URL's.


This change is Reviewable

Fixed a typo where /PSDesResources/ was used instead of /PSDscResources/ in some URL's.
@codecov-io
Copy link

Codecov Report

Merging #125 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #125   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        19     19           
  Lines      2755   2755           
  Branches      4      4           
===================================
  Hits       2300   2300           
  Misses      451    451           
  Partials      4      4

Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jsmartbnl - can you add an entry under the # Unreleased section of the README.MD mentioning this correction?

Awesome contribution and great catch!

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ jsmartbnl sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@jsmartbnl
Copy link
Author

@PlagueHO Thanks. Is this what you wanted?

@PlagueHO
Copy link
Contributor

@jsmartbnl - absolutely perfect! Now all you need to do is sign the CLA and we are good to merge. You only need to sign the CLA once.

@jsmartbnl
Copy link
Author

@PlagueHO - OK, I sent the CLA to my legal department yesterday as soon as it popped up as a pending check. I'll sign as soon as I get the all clear from legal.

@PlagueHO
Copy link
Contributor

Thank you @jsmartbnl ! We appreciate the contribution!

@PlagueHO
Copy link
Contributor

PlagueHO commented Jan 22, 2019

Awesome! Thanks @jsmartbnl - very much appreciated. Now unfortunately, I merged another change in the meantime which has caused some conflicts in your PR. Are you able to resolve the conflicts and I'll merge once CLA is done.

@PlagueHO PlagueHO added the waiting for CLA pass The contributor has not yet signed the CLA so that pull request check is not successful. label Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
waiting for CLA pass The contributor has not yet signed the CLA so that pull request check is not successful.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants