-
Notifications
You must be signed in to change notification settings - Fork 54
replace PSDesResources with PSDscResources in URLs #125
base: dev
Are you sure you want to change the base?
Conversation
Fixed a typo where /PSDesResources/ was used instead of /PSDscResources/ in some URL's.
Codecov Report
@@ Coverage Diff @@
## dev #125 +/- ##
===================================
Coverage 83% 83%
===================================
Files 19 19
Lines 2755 2755
Branches 4 4
===================================
Hits 2300 2300
Misses 451 451
Partials 4 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jsmartbnl - can you add an entry under the # Unreleased section of the README.MD mentioning this correction?
Awesome contribution and great catch!
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
|
@PlagueHO Thanks. Is this what you wanted? |
@jsmartbnl - absolutely perfect! Now all you need to do is sign the CLA and we are good to merge. You only need to sign the CLA once. |
@PlagueHO - OK, I sent the CLA to my legal department yesterday as soon as it popped up as a pending check. I'll sign as soon as I get the all clear from legal. |
Thank you @jsmartbnl ! We appreciate the contribution! |
Awesome! Thanks @jsmartbnl - very much appreciated. Now unfortunately, I merged another change in the meantime which has caused some conflicts in your PR. Are you able to resolve the conflicts and I'll merge once CLA is done. |
Fixed a typo where /PSDesResources/ was used instead of /PSDscResources/ in some URL's.
This change is