EDNSSubnetOpts refactoring

[omoerbeek]

Short description

Fixes #13704

Uses beter (rfc7871 derived) names things and introduced encapsulation to hide the internal representation of EDNSSubnetOpts.

Most of this are mechanical changes, the real stuff is in ednssubnet.??.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 12788152245

Details

• 175 of 183 (95.63%) changed or added relevant lines in 22 files are covered.
• 76 unchanged lines in 9 files lost coverage.
• Overall coverage decreased (-0.007%) to 64.895%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/dnspacket.cc	6	7	85.71%
pdns/stubresolver.cc	0	1	0.0%
pdns/dnsproxy.cc	2	4	50.0%
pdns/recursordist/lua-recursor4.cc	0	2	0.0%
pdns/recursordist/pdns_recursor.cc	13	15	86.67%

Files with Coverage Reduction	New Missed Lines	%
pdns/validate.cc	1	68.14%
pdns/recursordist/aggressive_nsec.cc	2	66.32%
pdns/packethandler.cc	3	72.74%
pdns/remote_logger.cc	3	53.81%
modules/lmdbbackend/lmdbbackend.cc	3	73.66%
pdns/recursordist/test-syncres_cc1.cc	8	89.68%
pdns/recursordist/syncres.cc	11	80.05%
pdns/recursordist/taskqueue.cc	11	34.15%
pdns/recursordist/rec-taskqueue.cc	34	40.14%

Totals
Change from base Build 12766545506:	-0.007%
Covered Lines:	126373
Relevant Lines:	163862

---

💛 - Coveralls

[miodvallat]

Looking good.

I was considering suggesting turning some of the setXXX routines into actual constructors, but it would add little value, if any.