Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hair trimming in pdnsutil #1 #15039

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Const me if you can.

27edf98
Select commit
Loading
Failed to load commit list.
Open

Hair trimming in pdnsutil #1 #15039

Const me if you can.
27edf98
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jan 15, 2025 in 2s

12 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 11 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 51 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Short global name Note

Poor global variable name 'S'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).

Check notice on line 52 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Short global name Note

Poor global variable name 'PC'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).

Check notice on line 53 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Short global name Note

Poor global variable name 'QC'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).

Check notice on line 90 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 139 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1031 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check warning on line 1170 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Use of goto Warning

Multiple forward and backward goto statements may make function editZone hard to understand.

Check notice on line 1323 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 2360 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 2476 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

FIXME comment Note

FIXME comment: this should reuse the constant from lmdbbackend but that is currently a #define in a .cc

Check notice on line 2581 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 4014 in pdns/pdnsutil.cc

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.